Skip to content

exhibitor: fix paths for zookeeper shell scripts #50348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

DzmitrySudnik
Copy link
Contributor

Motivation for this change

Exhibitor wants to change its local file and therefor in preInstall phase all files are copied from /nix/store to /var folder. However since starting zookeeper shell scripts are wrapped by nix (especially zkServer.sh after 6e9c7f0#diff-f80d089d8c5ac8a5901041c8810cb128) exhibitor still starts from the /nix/store, tries to modify files there and fails.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
  • Tested on NixOS box by running the updated service and validating that it's working as expected

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 14, 2018
@copumpkin
Copy link
Member

Not a huge fan of the hackery in the prestart script but it'll do for now, I guess, until someone decides to revamp it. Mind submitting a PR against 18.09 too for this? The service module is just broken, right?

@copumpkin copumpkin merged commit 9b7c57c into NixOS:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants