Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miro: remove #50354

Merged
merged 1 commit into from Nov 14, 2018
Merged

miro: remove #50354

merged 1 commit into from Nov 14, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 14, 2018

Motivation for this change

Uses old gstreamer (#39975), insecure version of webkitgtk, doesn't appear to be maintained upstream any more and it doesn't seem to work.

Stumbled upon whilst trying to purge some old ffmpeg's (#50220).

/cc @aszlig

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is from 2013 :/

@Mic92 Mic92 merged commit 4c3e9a7 into NixOS:master Nov 14, 2018
@pbogdan pbogdan mentioned this pull request Nov 22, 2018
13 tasks
@pbogdan pbogdan deleted the miro-remove branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants