New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.glom: init at 18.3.1 #51179
Conversation
There should be a single commit per package added. Also remove periods at end of descriptions in meta attribute. |
as you've added quite a bunch of new python packages: do you intend to maintain these packages in the future (if so, please add the |
7c4137b
to
9fe04f7
Compare
@Ma27 Ah, thanks for reminding me >.< Requested changes made. :) |
@GrahamcOfBorg build python27Packages.boltons python27Packages.face python27Packages.glom python37Packages.boltons python37Packages.face python37Packages.glom |
Success on aarch64-linux (full log) Attempted: python27Packages.boltons, python27Packages.face, python27Packages.glom, python37Packages.boltons, python37Packages.face, python37Packages.glom Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python27Packages.boltons, python27Packages.face, python27Packages.glom, python37Packages.boltons, python37Packages.face, python37Packages.glom Partial log (click to expand)
|
If so, we need to add an attribute to |
Additionally I'm seeing |
The version of |
It would be preferred, in this case, to use the github repo, which will have tests. |
Is that wise? Packages that rely on the PyPI version won't be able to use it as a dependency… |
This happens for relatively many packages. During the Or am I misunderstanding your concern? |
123f095
to
75c94b3
Compare
All requested changes made! How's it looking? |
Build fails because 2b9283a introduced a different version of glom in the meantime (as an application, but without the Python library). Please advise. |
Scratch that, it's actually a different application, we just have a name conflict. |
f4ce9e2
to
866a008
Compare
Have renamed |
Looking at repology |
I'd prefer it too, but we have strict rules on naming Python packages and less strict guidelines on other applications. I'm open to alternative suggestions though. |
I'm also okay with not packaging the application (at least until this is resolved), but perhaps @worldofpeace would be unhappy with that solution? |
This is glom's docs on their cli tool https://glom.readthedocs.io/en/latest/cli.html
I honestly don't think it's that important at this point to have it as an application in |
As the package states to be a "library first" I personally think that no top-level alias is needed, especially if it's still "under construction" (an "unstable" CLI is acceptable IMHO, but "under construction" is even worse). IIRC the top-level alias makes sense if you want to package an application which happens to be python based and is not intended to be a library, but correct me if I'm wrong :D |
1fcdaf7
to
2a397a2
Compare
Okay, removed the application. |
18dd4ca
to
aae98e5
Compare
@GrahamcOfBorg build pythonPackages.boltons python3Packages.boltons pythonPackages.face python3Packages.face pythonPackages.glom python3Packages.glom |
I think this is good, I'm going for it. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)