treewide: cross-fixes #51180
Merged
treewide: cross-fixes #51180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-linux (full log) Attempted: luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
globin
force-pushed
the
xorg-cross
branch
2 times, most recently
from
01d50fc
to
adaffa3
Compare
|
Some of this can't be built on staging due to ncurses failing cross there, have built these packages on a fork successfully. |
|
Success on x86_64-linux (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
globin
commented
Nov 29, 2018
| libX11 = super.libX11.overrideAttrs (attrs: { | ||
| outputs = [ "out" "dev" "man" ]; | ||
| configureFlags = attrs.configureFlags or [] | ||
| ++ malloc0ReturnsNullCrossFlag; | ||
| depsBuildBuild = [ buildPackages.stdenv.cc ]; |
There was a problem hiding this comment.
Not sure about this one @Ericson2314, this is one of the cases I mentioned a while ago where the build fails because there is no aarch64-unknown-linux-gnu-cpp and the build calls cc -E wrong.
This should probably be fixed by adding aarch64-unknown-linux-gnu-cpp and not by adding native cpp. This is also the case for ar.
$ ls /nix/store/n4lf26a3mqpnfh1m5rccj4pgxamrkjql-aarch64-unknown-linux-gnu-stage-final-gcc-debug-wrapper-7.3.0/bin/
aarch64-unknown-linux-gnu-as aarch64-unknown-linux-gnu-cc aarch64-unknown-linux-gnu-gcc aarch64-unknown-linux-gnu-ld.bfd
aarch64-unknown-linux-gnu-c++ aarch64-unknown-linux-gnu-g++ aarch64-unknown-linux-gnu-ld aarch64-unknown-linux-gnu-ld.gold
There was a problem hiding this comment.
No cpp? Woah that's weird. I could have sworn their once was.
There was a problem hiding this comment.
Fwiw, I have similar issue with libXt.
There was a problem hiding this comment.
I also have seen this problem somewhere else.
There was a problem hiding this comment.
I'll investigate, it's fine for now.
|
Success on x86_64-linux (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cups, luaPackages.luasocket, ssmtp, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: cups, luaPackages.luasocket, ssmtp, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: cups, luaPackages.luasocket, xorg.libX11, xorg.libXv The following builds were skipped because they don't evaluate on x86_64-darwin: ssmtp Partial log (click to expand)
|
c0bw3b
added
the
6.topic: cross-compilation
Ericson2314
approved these changes
Nov 29, 2018
Mic92
reviewed
Nov 30, 2018
| @@ -0,0 +1,35 @@ | |||
| From: Helmut Grohne <> | |||
There was a problem hiding this comment.
We had quite a few cross-build patches lately.
I think I should open a ticket, where reference the PRs for upstreaming.
There was a problem hiding this comment.
This is from an upstream issue that hasn't received any attention.
There was a problem hiding this comment.
Yeah. I could make it a proper pull request though. They maybe don't read all issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes xorg and luasocket cross builds.
Perl code could be deduplicated but not sure if worth the hassle.
Fixes #51178
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)