Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tradcpp: improved aarch64 support #51585

Merged
merged 1 commit into from Dec 7, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 5, 2018

Motivation for this change

Fixes #51578

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-review pr 51585
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Dec 5, 2018

@GrahamcOfBorg build tradcpp x11_ssh_askpass

@veprbl
Copy link
Member Author

veprbl commented Dec 5, 2018

I've just reported the bug and my patch to NetBSD.

#elif defined(__ARM__)
#define CONFIG_CPU "__ARM__"
+#elif defined(__aarch64__)
+#define CONFIG_CPU "__aarch64__"
Copy link
Member

@Mic92 Mic92 Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure netbsd would also accept this as a patch upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Why do you think so?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Sorry, I think I misread your comment. I agree, the patch is reasonable, so they probably will accept it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent it to dholland, the maintainer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a response:

On Fri, Dec 07, 2018 at 10:51:46AM +0000, J?rg Thalheim wrote:
 > This has been added in https://github.com/NixOS/nixpkgs/pull/51585

Several people sent this in more or less at once... anyway I just
posted a new tarball (0.5.3) with this and a few other similar bits.

Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 The other person must be me.

@Mic92 Mic92 merged commit dca1fe7 into NixOS:master Dec 7, 2018
@veprbl veprbl deleted the pr/tradcpp_aarch64_support branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants