New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tradcpp: improved aarch64 support #51585
Conversation
@GrahamcOfBorg build tradcpp x11_ssh_askpass |
I've just reported the bug and my patch to NetBSD. |
#elif defined(__ARM__) | ||
#define CONFIG_CPU "__ARM__" | ||
+#elif defined(__aarch64__) | ||
+#define CONFIG_CPU "__aarch64__" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sure netbsd would also accept this as a patch upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 Why do you think so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 Sorry, I think I misread your comment. I agree, the patch is reasonable, so they probably will accept it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sent it to dholland, the maintainer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a response:
On Fri, Dec 07, 2018 at 10:51:46AM +0000, J?rg Thalheim wrote:
> This has been added in https://github.com/NixOS/nixpkgs/pull/51585
Several people sent this in more or less at once... anyway I just
posted a new tarball (0.5.3) with this and a few other similar bits.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mic92 The other person must be me.
Motivation for this change
Fixes #51578
Things done
sandbox
innix.conf
on non-NixOS)nix-review pr 51585
./result/bin/
)nix path-info -S
before and after)