Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana: 5.3.4 -> 5.4.0 #51583

Merged
merged 2 commits into from Dec 8, 2018
Merged

grafana: 5.3.4 -> 5.4.0 #51583

merged 2 commits into from Dec 8, 2018

Conversation

WilliButz
Copy link
Member

Motivation for this change

Latest release which includes various bugfixes, some new features and also a "breaking change" regarding database connection limits.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Successfully ran tests for 86_64-linux and aarch64-linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I updated the default for database.connMaxLifetime in the module.

(Note that go still failes to compile grafana on hosts with too many available cores.)

@markuskowa
Copy link
Member

@GrahamcOfBorg build nixosTests.grafana

@markuskowa markuskowa merged commit 86d80a7 into NixOS:master Dec 8, 2018
@WilliButz WilliButz deleted the grafana-update branch December 11, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants