Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x2goclient: fix build #51586

Closed
wants to merge 1 commit into from
Closed

x2goclient: fix build #51586

wants to merge 1 commit into from

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Dec 5, 2018

Motivation for this change

Build has been broken since the libssh 0.7 -> 0.8 upgrade.
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.x2goclient.x86_64-linux

Note that this builds a non-release version, but has the added benefit of getting rid of the qt5 compatibility patch (and is probably preferrable to manually picking more patches to the 4 months old release).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build x2goclient

@worldofpeace
Copy link
Contributor

Merged in 561959b with some minor nitpicks

@averelld Thanks for the fix ❇️

@averelld averelld deleted the x2goclient-fix branch December 6, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants