Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.flake8-future-import: fix build on Python 3.7 #51599

Merged
merged 1 commit into from Dec 6, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 6, 2018

Motivation for this change

Fixes #51593

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.flake8-future-import python3Packages.flake8-future-import

@worldofpeace
Copy link
Contributor

I'm seeing these errors on hydra before this so I guess we can ignore it

File "badsyntax_future3" not found.
File "badsyntax_future4" not found.

@worldofpeace worldofpeace merged commit 0ab30b1 into NixOS:master Dec 6, 2018
@worldofpeace
Copy link
Contributor

Thanks again @marsam ❇️

@marsam marsam deleted the fix-flake8-future-import-build branch December 6, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants