heaptrack: wrap GUI for QT plugins #51597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `heaptrack_gui` program requires QT plugins. This works if it's included in a full install, since QT will search the users' `$PATH` for plugins; however it immediately crashes if run in a pure environment. This wraps the program to find the given `qtbase` plugins directory without requiring an impure installation. Related: NixOS#9680
|
@GrahamcOfBorg build heaptrack |
Mic92
reviewed
Dec 13, 2018
| qtbase kio kitemmodels threadweaver kconfigwidgets kcoreaddons kdiagram | ||
| ]; | ||
|
|
||
| postInstall = '' | ||
| wrapProgram $out/bin/heaptrack_gui --set QT_PLUGIN_PATH ${qtbase}/${qtbase.qtPluginPrefix} |
There was a problem hiding this comment.
Have you tried to install heaptrack_gui in your nix profile?
There was a problem hiding this comment.
The impurity for qt is necessary because the way qt searches for plugins.
There was a problem hiding this comment.
Indeed, it works just fine when impurely installed and run through a user profile. However, with this change it also works when package is used outside of a nix-env.
There was a problem hiding this comment.
Setting QT_PLUGIN_PATH will break integration with desktop environments: #24256 (comment)
This needs to be fixed in a central place.
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
heaptrack_guiprogram requires QT plugins. This works if it's included ina full install, since QT will search the users'
$PATHfor plugins; however itimmediately crashes if run in a pure environment.
This wraps the program to find the given
qtbaseplugins directory withoutrequiring an impure installation.
Related: #9680
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)