Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tecoc: add BSD and Darwin/OSX support #51598

Merged
merged 1 commit into from Dec 15, 2018
Merged

tecoc: add BSD and Darwin/OSX support #51598

merged 1 commit into from Dec 15, 2018

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Dec 6, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Dec 6, 2018
@AndersonTorres
Copy link
Member Author

A fast question: it uses a custom open source oldschool license - "do what you want, and if you modify it, make it clear it is a modified version".

What should I put in license?

Another question: can someone test Darwin for me? 😸

@markuskowa
Copy link
Member

It very loosely resembles the meaning of the Apache license. However, from what I can see, I would consider it a non-standard license. A simple way to go about it would be to just give the link:

license = {  url = https://github.com/blakemcbride/TECOC/tree/master/doc; };

@AndersonTorres
tecoc: add BSD and Darwin/OSX support
c1a9af1 
Also, change some minor things.
@matthewbauer matthewbauer merged commit ac22b8d into NixOS:master Dec 15, 2018
@AndersonTorres AndersonTorres deleted the upload/tecoc branch January 31, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @markuskowa @matthewbauer @GrahamcOfBorg