Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yed: 3.18.1.1 -> 3.18.2 #51592

Merged
merged 1 commit into from Dec 7, 2018
Merged

yed: 3.18.1.1 -> 3.18.2 #51592

merged 1 commit into from Dec 7, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

Bump yEd, current derivation won't fetch anymore, they removed the src archive.

Change requireFile to fetchzip because that's what Arch Linux does and EULA doesn't seem to prohibit automated downloads.

cc @orivej

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Dec 6, 2018

Isn't the fact that the download is normally locked behind a EULA sufficient to argue that requireFile is the right way?

@rasendubi
Copy link
Member

rasendubi commented Dec 6, 2018 •
edited

There was a similar precedent for VirtualBox extension pack #44896. Download requires accepting VirtualBox Personal Use and Evaluation License (PUEL), so the PR added virtualbox-puel license to nixpkgs.

@Mic92 Mic92 merged commit fc7eef5 into master Dec 7, 2018
@lukateras lukateras deleted the yegortimoshenko-patch-1 branch December 7, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukateras @srhb @rasendubi @Mic92 @GrahamcOfBorg