Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-docs: init at 0.5.0 #51579

Merged
merged 3 commits into from Dec 6, 2018
Merged

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 5, 2018

Motivation for this change

Package needed

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it builds and executes.
I've also tested their examples and it functions properly 👍

@zimbatm
Copy link
Member Author

zimbatm commented Dec 6, 2018

thanks @worldofpeace for the review!

@zimbatm zimbatm merged commit e4d06cb into NixOS:master Dec 6, 2018
@zimbatm zimbatm deleted the terraform-docs-0.5.0 branch December 6, 2018 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants