Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsjail: 2.7 -> 2.8 #50973

Merged
merged 1 commit into from Nov 24, 2018
Merged

nsjail: 2.7 -> 2.8 #50973

merged 1 commit into from Nov 24, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 23, 2018

Motivation for this change

Changelog: https://github.com/google/nsjail/releases/tag/2.8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ ./result/bin/nsjail -Mo --chroot / -- /run/current-system/sw/bin/echo "ABC"
[2018-11-24T00:23:06+0100] Mode: STANDALONE_ONCE
[2018-11-24T00:23:06+0100] Jail parameters: hostname:'NSJAIL', chroot:'/', process:'/run/current-system/sw/bin/echo', bind:[::]:0, max_conns_per_ip:0, time_limit:0, personality:0, daemonize:false, clone_newnet:true, clone_newuser:true, clone_newns:true, clone_newpid:true, clone_newipc:true, clonew_newuts:true, clone_newcgroup:true, keep_caps:false, disable_no_new_privs:false, max_cpus:0
[2018-11-24T00:23:06+0100] Mount point: '/' -> '/' flags:MS_RDONLY|MS_BIND|MS_REC|MS_PRIVATE type:'' options:'' is_dir:true
[2018-11-24T00:23:06+0100] Mount point: '/proc' flags:MS_RDONLY type:'proc' options:'' is_dir:true
[2018-11-24T00:23:06+0100] Uid map: inside_uid:1000 outside_uid:1000 count:1 newuidmap:false
[2018-11-24T00:23:06+0100] Gid map: inside_gid:100 outside_gid:100 count:1 newgidmap:false
[2018-11-24T00:23:06+0100] Executing '/run/current-system/sw/bin/echo' for '[STANDALONE MODE]'
ABC
[2018-11-24T00:23:06+0100] PID: 3365 ([STANDALONE MODE]) exited with status: 0, (PIDs left: 0)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nsjail

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8
shrinking /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8/bin/nsjail
gzipping man pages under /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8/bin
patching script interpreter paths in /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8
checking for references to /build in /nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8...
/nix/store/5swg4sy3w0g0h0pdrksdkzzhfl50q63p-nsjail-2.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nsjail

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8
shrinking /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8/bin/nsjail
gzipping man pages under /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8/bin
patching script interpreter paths in /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8
checking for references to /build in /nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8...
/nix/store/zx1hd6qxkcqyv884k2bxv9ci1abcrpyy-nsjail-2.8

@7c6f434c 7c6f434c merged commit f79bf0a into NixOS:master Nov 24, 2018
@c0bw3b c0bw3b deleted the pkg/nsjail branch November 25, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @7c6f434c