sarasa-gothic: rewrite: TTC and fixed-output #50974
Merged
+12
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewritten to use TTC archive instead of the TTF one, which drastically shrinks the closure size. (2.2G to 212M on v0.6.0.) It's also now fixed-output.
|
Uhh, the diff is a whole mess. It's probably better to just read the whole file. |
GrahamcOfBorg
added
8.has: package (new)
c0bw3b
added
8.has: package (update)
|
Thanks! |
|
Hello and thanks for the contribution. Reducing closure size by a factor 10 and making it fixed-output is certainly welcomed. To me removing Note: it seems a v0.7 has been released 2 days ago. Your PR could also update the font at the same time. |
|
( woops been writing while it was merged :p ) |
|
As the maintainer of |
12 tasks
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten to use TTC archive instead of the TTF one. It's also now fixed-output.
Motivation for this change
The current sarasa-gothic font takes up 2.2GB in the Nix store. This can be reduced to 212MB by using the TTC archive instead of the TTF one, which shares data between individual fonts and has a much smaller size than the sum of individual fonts.
It was written like
wqy_zenhei. It, as it has been, does not usefetchzipbecausep7zipis needed.Also I've made it fixed-output like
wqy_zenhei. This should avoid unnecessary re-builds.I have not kept
hydraPlatforms = []due to the size having drastically decreased. Is this acceptable? (cc @Mic92)nix path-info -Soutput showing the improvement:Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)