Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.23.1 -> 1.23.2 #48820

Closed
wants to merge 1 commit into from
Closed

libuv: 1.23.1 -> 1.23.2 #48820

wants to merge 1 commit into from

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Oct 22, 2018

Motivation for this change

I was having trouble updating LXD and I thought maybe this had to do with it; it didn't. Nevertheless, I ended using this bugfix release on my systems and seems to be working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Oct 22, 2018

@GrahamcOfBorg build libuv

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libuv

Partial log (click to expand)

 /nix/store/5s4072bfj6q40mhw5hgb8y4lbmgwrbga-coreutils-8.30/bin/install -c -m 644 include/uv/errno.h include/uv/threadpool.h include/uv/version.h include/uv/unix.h include/uv/linux.h '/nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2/include/uv'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2
shrinking /nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2/lib/libuv.so.1.0.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2/lib
patching script interpreter paths in /nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2
checking for references to /build in /nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2...
/nix/store/r6hv3w2cqp65n3y20zp2k246nyjbiwsh-libuv-1.23.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libuv

Partial log (click to expand)

 /nix/store/dzvbhkzfgwkq97ljkcvi4gs7vmflh6a0-coreutils-8.30/bin/install -c -m 644 include/uv/errno.h include/uv/threadpool.h include/uv/version.h include/uv/unix.h include/uv/linux.h '/nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2/include/uv'
make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2
shrinking /nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2/lib/libuv.so.1.0.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2/lib
patching script interpreter paths in /nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2
checking for references to /build in /nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2...
/nix/store/54rs9zhpmph7klk78i83k8awddb2wc4x-libuv-1.23.2

@xeji
Copy link
Contributor

xeji commented Oct 23, 2018

@GrahamcOfBorg eval

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 25, 2018

Done in #50044

@c0bw3b c0bw3b closed this Nov 25, 2018
@jokogr jokogr deleted the u/libuv-1.23.2 branch February 26, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jokogr @bhipple @GrahamcOfBorg @xeji @c0bw3b