Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8821a: init at 5.1.5 #51018

Merged
merged 2 commits into from Dec 18, 2018
Merged

rtl8821a: init at 5.1.5 #51018

merged 2 commits into from Dec 18, 2018

Conversation

plchldr
Copy link
Contributor

@plchldr plchldr commented Nov 25, 2018

Motivation for this change

I needed this driver for my new USB WLAN adapter (rtl8811au).

Things done

For this I've merged together

I guess there's an argument to be made to add a make flag CONFIG_RTL8812A=n, so the resulting module is named "8821a" instead of "8812a" and so doesn't conflict with the better suited driver for this chipset.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Dec 7, 2018

I guess there's an argument to be made to add a make flag CONFIG_RTL8812A=n, so the resulting module is named "8821a" instead of "8812a" and so doesn't conflict with the better suited driver for this chipset.

What would the argument against this be?

@matthewbauer matthewbauer merged commit 06bf67d into NixOS:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants