Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keybase software #51008

Merged
merged 3 commits into from Nov 25, 2018
Merged

Update Keybase software #51008

merged 3 commits into from Nov 25, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Nov 25, 2018 •
edited

Motivation for this change

Requested in #50999

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin
shrinking /nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin/bin/keybase
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin/bin
patching script interpreter paths in /nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin
checking for references to /build in /nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin...
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
/nix/store/6vvwpp36gg1wd4g8zal990bsp0bnl142-kbfs-2.10.1-bin
/nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin
/nix/store/w9s860y5zjbnvp1zkbfm44x4mcr2mdxz-keybase-gui-2.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin
shrinking /nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin/bin/keybase
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin/bin
patching script interpreter paths in /nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin
checking for references to /build in /nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin...
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
/nix/store/fgw07rncb2zyjgbn9yd7jic0wy6pr9pz-kbfs-2.10.1-bin
/nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin
/nix/store/c4635gcda0irr6df38jsa6maz1bm56z9-keybase-gui-2.11.0

@worldofpeace
keybase-gui: 2.7.0 -> 2.11.0
ab65d6c 
- Use `autoPatchelfHook`
- Don't explicitly set phases - Part of NixOS#28910
- Correct `version` by hoisting out the suffix
@worldofpeace
keybase: 2.7.3 -> 2.10.1
f442f56
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

  libffmpeg.so -> found: /nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0/share/keybase/libffmpeg.so
  libasound.so.2 -> found: /nix/store/720n32zm5w9nbq7zz6ibad4ab7sg3vn2-alsa-lib-1.1.7/lib/libasound.so.2
  libcups.so.2 -> found: /nix/store/ip7b09ks2c7qzzszfkmjvapi151pjkpw-cups-2.2.6-lib/lib/libcups.so.2
  libfontconfig.so.1 -> found: /nix/store/f5aq9p3v96n0jdviaj6iska38z06vaqb-fontconfig-2.12.6-lib/lib/libfontconfig.so.1
  libexpat.so.1 -> found: /nix/store/2gfw7fiss8m86mmjfcf45n3i60xyhk33-expat-2.2.6/lib/libexpat.so.1
setting RPATH to: /nix/store/k95d8c6gv4klrwf061hqnr9l8q53gvlk-systemd-239-lib/lib:/nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0/share/keybase:/nix/store/66h9b9qanqjd848nh0cxhhn4daj5f19l-gtk+3-3.22.30/lib:/nix/store/66h9b9qanqjd848nh0cxhhn4daj5f19l-gtk+3-3.22.30/lib:/nix/store/d7axxsgwsbh2isjgv813z7chnhp66v4p-pango-1.42.4/lib:/nix/store/d7axxsgwsbh2isjgv813z7chnhp66v4p-pango-1.42.4/lib:/nix/store/b3ca42n3vkaa85a9ivdl310izswcma4r-atk-2.28.1/lib:/nix/store/vgjgw273fl8yx6iljnagzgfzlf09rhxn-cairo-1.16.0/lib:/nix/store/cp0w3abqg4f57xw04z0k53g3q3p57b3r-gdk-pixbuf-2.36.12/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/b8vp3w9ckczdg38wp3p6pjqixdvf1vfc-at-spi2-atk-2.26.2/lib:/nix/store/da43a7cy7b4yxlh6da5fjdi95fh10agb-dbus-1.12.10-lib/lib:/nix/store/igkgqwdrxbj3980lsbmc1lawgmn79frf-libX11-1.6.6/lib:/nix/store/k9hkf1kch3y3gfp1cjfnfppn43g27jq8-libxcb-1.13.1/lib:/nix/store/qjpvc33cfyi2c82a50459w5v3x16jzjl-libXi-1.7.9/lib:/nix/store/ai26lxxkj05792z57y2zrwbmbajcb0kc-libXcursor-1.1.15/lib:/nix/store/smmj9c954l6i0sib24mzmb0gs01agm5r-libXdamage-1.1.4/lib:/nix/store/87wrz5bw83sa25bdxa2zszhr20qzwd4m-libXrandr-1.5.1/lib:/nix/store/pmyad8xy9a2ppqzq2g6zdg2g4qjswdf5-libXcomposite-0.4.4/lib:/nix/store/nx7na47silpayvq08ip6qn1ds478a7d7-libXext-1.3.3/lib:/nix/store/vlkg2q9bigb1hk73qgjaw4d5qg73ssy1-libXfixes-5.0.3/lib:/nix/store/5b9fji2bg51dw5v1an6ryvnm5adrzzpd-libXrender-0.9.10/lib:/nix/store/igkgqwdrxbj3980lsbmc1lawgmn79frf-libX11-1.6.6/lib:/nix/store/wri6b6m49vbfjxq5fplv9lgxph4cnsxg-libXtst-1.2.3/lib:/nix/store/4g5xdbd47d0a75yl6v3l3fc40chqaaj5-libXScrnSaver-1.2.2/lib:/nix/store/9vfvinsf2blx98nqxhxgs4csna3v88jn-glib-2.56.0/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/yhvjkyyb0jx0vsb5pd16gr04j1rlvwbc-nss-3.39/lib:/nix/store/93w914f7mnhhsck2f5jwlbbxv9hgr86z-nspr-4.20/lib:/nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0/share/keybase:/nix/store/720n32zm5w9nbq7zz6ibad4ab7sg3vn2-alsa-lib-1.1.7/lib:/nix/store/ip7b09ks2c7qzzszfkmjvapi151pjkpw-cups-2.2.6-lib/lib:/nix/store/f5aq9p3v96n0jdviaj6iska38z06vaqb-fontconfig-2.12.6-lib/lib:/nix/store/2gfw7fiss8m86mmjfcf45n3i60xyhk33-expat-2.2.6/lib
cannot link '/nix/store/.links/0mpcqr0pkxdzy8rr68yip7i9xhv858cm03plzbkq2ay6l68yrqj1' to '/nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0/share/keybase/resources/app/desktop/dist/unlock-folders.bundle.js': No space left on device
/nix/store/fgw07rncb2zyjgbn9yd7jic0wy6pr9pz-kbfs-2.10.1-bin
/nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin
/nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

/nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/post_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0...
automatically fixing dependencies for ELF files
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/Keybase
setting RPATH to: /nix/store/59mnmymn74qg44nhdjsfg5h210nc3lcj-systemd-239-lib/lib
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/libnode.so
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/libffmpeg.so
/nix/store/6vvwpp36gg1wd4g8zal990bsp0bnl142-kbfs-2.10.1-bin
/nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin
/nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

/nix/store/fgw07rncb2zyjgbn9yd7jic0wy6pr9pz-kbfs-2.10.1-bin
/nix/store/bmab38bph1jqyxs0vkrz3qh2q3qm13hd-keybase-2.10.1-bin
/nix/store/kjppp5lzdxsa77swr1d7rh86z89y4d8g-keybase-gui-2.11.0

@worldofpeace
Copy link
Contributor Author

cc @colemickens @jonafato (for testing)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kbfs, keybase, keybase-gui

Partial log (click to expand)

/nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/post_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/n1kfdl37qpzh3xn6klbym1ay6xpxvmw1-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0...
automatically fixing dependencies for ELF files
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/libnode.so
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/libffmpeg.so
searching for dependencies of /nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0/share/keybase/Keybase
setting RPATH to: /nix/store/59mnmymn74qg44nhdjsfg5h210nc3lcj-systemd-239-lib/lib
/nix/store/6vvwpp36gg1wd4g8zal990bsp0bnl142-kbfs-2.10.1-bin
/nix/store/84nv1cxl28y67gc5g0kpysjpcadpwvkp-keybase-2.10.1-bin
/nix/store/3mx0az81myx2y5k18hbl4y2j4kb93x8w-keybase-gui-2.11.0

rvolosatovs
rvolosatovs approved these changes Nov 25, 2018
View reviewed changes
Copy link
Member

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbfs and keybase CLI seem to work fine. Didn't try the GUI.

@worldofpeace
Copy link
Contributor Author

Sounds good, merging.

@worldofpeace worldofpeace merged commit b49ed49 into NixOS:master Nov 25, 2018
@worldofpeace worldofpeace deleted the keybase-updates branch November 25, 2018 21:44
@devhell
Copy link
Contributor

devhell commented Dec 9, 2018

Got a message from keybase telling me that this needs updating to 2.11 (apparently they'll disable old version access, or so they claim). I'm currently in no position to do any testing, which is why I'm mentioning it here.

@jonafato
Copy link
Contributor

It looks like this change is already on nixos-unstable, nixos-unstable-small, nixos-18.09, and nixos-18.09-small, but it still needs to be added to nixpkgs-unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvolosatovs rvolosatovs rvolosatovs approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@worldofpeace @GrahamcOfBorg @devhell @jonafato @rvolosatovs @c0bw3b