Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS mass fix and rebalance #1946

Merged
merged 6 commits into from
Dec 5, 2018
Merged

Conversation

MikeOnTea
Copy link
Contributor

@MikeOnTea MikeOnTea commented Nov 24, 2018

PR #1842 broke the rcs mass calculation in an attempt to fix #1769, resulting in single nozzle thrusters having a mass of 1/8 of a quad thruster with the same thrust, for example. The real issue was just poor balancing though, the calculation itself worked as intended before the patch.

Here's my attempt to fix this. Doing some research for balancing, it seems rcs thruster mass scales roughly proportional to sqrt(thrust) instead of linearly with thrust (see here, here or here), so this is what i did as well.
I also reduced the mass savings for multi nozzle thrusters, according to one real world example i found here.

These changes result in the following masses (for TL2 thrusters):

Thruster Mass
28/45 N 1.7 kg
138/223 N 3.8 kg
138/223 N quad 11.3 kg
275/445 N quad 16 kg
550/890 N 7.5 kg
1.1/1.78 kN 10.7 kg
2.2/3.6 kN 15.1 kg

I also fixed and changed the scaling of the parts slightly (for rcs parts) or not so slightly (for the 1/2 kN thrusters, they were a bit on the small side i think, the latter now got a nozzle diameter of 45 cm, a little larger than the slighly lower Isp AR R-40B).

Edit: As siimav suggested i now changed the 1/2 kn thrusters' models to OMS Large if VSR is installed, those look better for a vacuum thruster i think:

image

@MikeOnTea MikeOnTea changed the title RCS fix and rebalance RCS mass fix and rebalance Nov 24, 2018
masses are now scaling by sqrt(thrust) and the mass savings for multi-nozzle-thrusters return, albeit rebalanced to be lower
@pap1723
Copy link
Contributor

pap1723 commented Dec 5, 2018

This is a good fix, HOWEVER be aware that these changes can be craft breaking as the sizes are pretty large for the single Thruster engines. These are a lot more accurate.

@pap1723 pap1723 merged commit 512b86f into KSP-RO:master Dec 5, 2018
@siimav
Copy link
Contributor

siimav commented Dec 5, 2018

I have tested these changes and the new balancing looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken 2 kN thruster in DEV BRANCH
3 participants