Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1842 broke the rcs mass calculation in an attempt to fix #1769, resulting in single nozzle thrusters having a mass of 1/8 of a quad thruster with the same thrust, for example. The real issue was just poor balancing though, the calculation itself worked as intended before the patch.
Here's my attempt to fix this. Doing some research for balancing, it seems rcs thruster mass scales roughly proportional to sqrt(thrust) instead of linearly with thrust (see here, here or here), so this is what i did as well.
I also reduced the mass savings for multi nozzle thrusters, according to one real world example i found here.
These changes result in the following masses (for TL2 thrusters):
I also fixed and changed the scaling of the parts slightly (for rcs parts) or not so slightly (for the 1/2 kN thrusters, they were a bit on the small side i think, the latter now got a nozzle diameter of 45 cm, a little larger than the slighly lower Isp AR R-40B).
Edit: As siimav suggested i now changed the 1/2 kn thrusters' models to OMS Large if VSR is installed, those look better for a vacuum thruster i think: