Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyproj: 1.9.5.1 -> unstable-2018-11-13 #50982

Merged
merged 1 commit into from Nov 25, 2018
Merged

pythonPackages.pyproj: 1.9.5.1 -> unstable-2018-11-13 #50982

merged 1 commit into from Nov 25, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Allow us to build pyproj with python3.7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
pythonPackages.pyproj: 1.9.5.1 -> unstable-2018-11-13
6a51299 
Allows us to build pyproj with python3.7.

See: pyproj4/pyproj#136
worldofpeace
worldofpeace commented Nov 24, 2018
View reviewed changes
pkgs/development/python-modules/pyproj/default.nix
};

buildInputs = [ nose2 ];
buildInputs = [ cython ];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need cython when if we clone the github repo. https://github.com/jswhit/pyproj#installation

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.pyproj python3Packages.pyproj pythonPackages.owslib python3Packages.owslib

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.pyproj, python3Packages.pyproj, pythonPackages.owslib, python3Packages.owslib

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/gn78qv7b33kicqv3yi499pwcqbkdvkqx-python3.7-OWSLib-0.17.0
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gn78qv7b33kicqv3yi499pwcqbkdvkqx-python3.7-OWSLib-0.17.0/lib
patching script interpreter paths in /nix/store/gn78qv7b33kicqv3yi499pwcqbkdvkqx-python3.7-OWSLib-0.17.0
checking for references to /build in /nix/store/gn78qv7b33kicqv3yi499pwcqbkdvkqx-python3.7-OWSLib-0.17.0...
pytestcachePhase
/nix/store/2a9wc1i6fkk7zh29sa8ap99l2v8y4zva-python2.7-pyproj-unstable-2018-11-13
/nix/store/sz295a21m51gw89ix9ncv97chs7y3919-python3.7-pyproj-unstable-2018-11-13
/nix/store/kfp325mwjkjx14kick8siqyr642p98md-python2.7-OWSLib-0.17.0
/nix/store/gn78qv7b33kicqv3yi499pwcqbkdvkqx-python3.7-OWSLib-0.17.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.pyproj, python3Packages.pyproj, pythonPackages.owslib, python3Packages.owslib

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ip92ydbl1r79fij9w4yy3n6gpgqkjg7k-python2.7-OWSLib-0.17.0
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ip92ydbl1r79fij9w4yy3n6gpgqkjg7k-python2.7-OWSLib-0.17.0/lib
patching script interpreter paths in /nix/store/ip92ydbl1r79fij9w4yy3n6gpgqkjg7k-python2.7-OWSLib-0.17.0
checking for references to /build in /nix/store/ip92ydbl1r79fij9w4yy3n6gpgqkjg7k-python2.7-OWSLib-0.17.0...
pytestcachePhase
/nix/store/gfqh1icgn3l4hrhazzgwandw34p9liqn-python2.7-pyproj-unstable-2018-11-13
/nix/store/rpha9710ic4jpc6352ws3i16iwqqq261-python3.7-pyproj-unstable-2018-11-13
/nix/store/ip92ydbl1r79fij9w4yy3n6gpgqkjg7k-python2.7-OWSLib-0.17.0
/nix/store/czfmhkvn7wcsph8b6igv0icdv2m57wby-python3.7-OWSLib-0.17.0

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.geopandas python3Packages.geopandas

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pythonPackages.geopandas, python3Packages.geopandas

Partial log (click to expand)


tests/tslibs/test_parsing.py::TestGuessDatetimeFormat::()::test_guess_datetime_format_nopadding[2011-1-3T00:00:0-%Y-%m-%dT%H:%M:%S]
  /nix/store/22gkkcp1n5vjwarb239mjpqhj11d3i9s-python2.7-python-dateutil-2.7.3/lib/python2.7/site-packages/dateutil/parser/__init__.py:46: DeprecationWarning: _timelex is a private class and may break without warning, it will be moved and or renamed in future versions.
    warnings.warn(msg, DeprecationWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 5 failed, 16896 passed, 1030 skipped, 11887 deselected, 37 xfailed, 2 xpassed, 98 warnings in 602.21 seconds
builder for '/nix/store/46s7db96ihy9zyafss162n6bwhm4648i-python2.7-pandas-0.23.4.drv' failed with exit code 1
cannot build derivation '/nix/store/crqn9bspsrf8pnjzmmydbz4c3ajxkfpm-python2.7-geopandas-0.4.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/crqn9bspsrf8pnjzmmydbz4c3ajxkfpm-python2.7-geopandas-0.4.0.drv', '/nix/store/h0vjncncg506ys672bnbqc899bkx1yi9-python3.7-geopandas-0.4.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: pythonPackages.geopandas, python3Packages.geopandas

Partial log (click to expand)

    result = overlay(df1, df2, how=how, use_sindex=use_sindex)

geopandas/tests/test_types.py::TestSeries::()::test_select
  /build/source/geopandas/geoseries.py:131: FutureWarning: 'select' is deprecated and will be removed in a future release. You can use .loc[labels.map(crit)] as a replacement
    val = getattr(super(GeoSeries, self), mtd)(*args, **kwargs)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
 301 passed, 14 skipped, 1 deselected, 7 xfailed, 38 warnings in 109.38 seconds
pytestcachePhase
error: build of '/nix/store/kwqxss6fidlks2i3vrwfiqkhkj2f7252-python3.7-geopandas-0.4.0.drv' failed

@dotlambda dotlambda mentioned this pull request Nov 25, 2018
Merged
10 tasks
@dotlambda dotlambda merged commit a339dda into NixOS:master Nov 25, 2018
@worldofpeace worldofpeace deleted the pyproj/unstable branch November 25, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @dotlambda