Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: wrap git-credential-netrc to set PERL5LIB #50992

Merged
merged 1 commit into from
Dec 14, 2018
Merged

git: wrap git-credential-netrc to set PERL5LIB #50992

merged 1 commit into from
Dec 14, 2018
+3 −1

Conversation

cyounkins
Copy link
Contributor

Motivation for this change

Fixes #48199

@manveru @volth

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 24, 2018

Could you also target this at the staging branch?

@cyounkins
Copy link
Contributor Author

cyounkins commented Nov 25, 2018 •
edited
Loading

When basing the diff off the staging branch, I'm getting this error when trying to install using the local clone: trace: version 19.03.git.6f2475f does not appear in name nixos-version

Full output: https://gist.github.com/cyounkins/4d8c4ced79742c47d01586078f00dbea

Am I doing something stupid? I'm doing pretty much what is in https://nixos.wiki/wiki/Nixpkgs/Create_and_debug_packages

Edit: seems related to this commit 320c9c1

@cyounkins
Copy link
Contributor Author

For my staging issue: #51071 and #50364

@cyounkins cyounkins changed the base branch from master to staging December 6, 2018 19:50
@cyounkins
Copy link
Contributor Author

Oops, sorry for the noise. Now targeting staging

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation labels Dec 6, 2018
@GrahamcOfBorg GrahamcOfBorg added 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 6, 2018
@cyounkins
Copy link
Contributor Author

Is anyone able to review?

@zimbatm zimbatm merged commit 921d046 into NixOS:staging Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk

@Ericson2314 Ericson2314

@FRidh FRidh

@infinisil infinisil

@matthewbauer matthewbauer

@peti peti

@ryantm ryantm

@thoughtpolice thoughtpolice

@zimbatm zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyounkins @c0bw3b @zimbatm @GrahamcOfBorg