Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgpg-error: Enable Aarch32 support for musl #51013

Merged
merged 2 commits into from Dec 4, 2018
Merged

libgpg-error: Enable Aarch32 support for musl #51013

merged 2 commits into from Dec 4, 2018

Conversation

tathougies
Copy link
Contributor

Motivation for this change

Following a similar change for x86-64 and musl, we need to copy some files over for arm32 and musl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b reviewed Nov 26, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you commit short message should look like the PR title :)

pkgs/development/libraries/libgpg-error/default.nix Show resolved Hide resolved
@tathougies
Copy link
Contributor Author

Can I change the commit short message after the fact?

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 26, 2018 •
edited

To change the commit short message you would need to git commit --amend (assuming the commit you want to edit is the last one) and force-push to your travis/libgpg-error-arm branch after edition.
It will refresh this PR automatically (we'll see only the new rewritten commit)
(double check your git log before force pushing though)

@lheckemann
Copy link
Member

Any reason you used cp rather than ln like the others?

@tathougies
Copy link
Contributor Author

@lheckemann No particular reason. I'll change it to match.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@GrahamcOfBorg build libgpgerror

@c0bw3b c0bw3b merged commit b682e03 into NixOS:master Dec 4, 2018
@delroth
Copy link
Contributor

delroth commented Apr 17, 2019

I don't believe this change ever worked after you switched cp -> ln. The symlinks are broken because the directory name is repeated in the symlink source (compare the x86_64 command vs. aarch32 command).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tathougies @c0bw3b @lheckemann @delroth @GrahamcOfBorg