Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune/jbuilder: 1.0.1 -> 1.5.1 #50997

Closed
wants to merge 1 commit into from
Closed

dune/jbuilder: 1.0.1 -> 1.5.1 #50997

wants to merge 1 commit into from

Conversation

Sophia-Gold
Copy link
Contributor

@Sophia-Gold Sophia-Gold commented Nov 24, 2018 •
edited

Motivation for this change

Bumped dune to version 1.5.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Sophia-Gold
Copy link
Contributor Author

Sophia-Gold commented Nov 24, 2018 •
edited

Ugh, this may have been too soon: ocaml/dune#1548. I would wait to merge.

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 13, 2018

Dune is already in nixpkgs and is already at 1.5.1. I suppose the jbuilder package is mostly provided for compatibility so there is not much point to update it.

@Mic92 Mic92 changed the title dune/jbuilder 1.5.1 dune/jbuilder: 1.0.1 -> 1.5.1 Dec 13, 2018
@Sophia-Gold
Copy link
Contributor Author

Sorry, not sure why I didn't check first. 18.09 still used the name jbuilder.

@Sophia-Gold Sophia-Gold deleted the release-18.09 branch December 14, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 9.needs: upstream fix 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sophia-Gold @Zimmi48 @c0bw3b @GrahamcOfBorg