Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treewide: use HTTPS for repo.or.cz and SF.net #50989

Merged
merged 2 commits into from Nov 24, 2018
Merged

Treewide: use HTTPS for repo.or.cz and SF.net #50989

merged 2 commits into from Nov 24, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 24, 2018 •
edited

Motivation for this change

https://repo.or.cz/ repo now uses a trusted Let's Encrypt certificate and http:// redirects to https://

+ replaced links to SourceForge still using http://

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b changed the title Treewide: use HTTPS for repo.or.cz Treewide: use HTTPS for repo.or.cz and SF.net Nov 24, 2018
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2018

@GrahamcOfBorg build a2jmidid

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: a2jmidid

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: a2jmidid

Partial log (click to expand)

shrinking /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/bin/a2jmidi_bridge
shrinking /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/bin/j2amidi_bridge
gzipping man pages under /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/bin
patching script interpreter paths in /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8
/nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/bin/a2j: interpreter directive changed from "/bin/sh" to "/nix/store/n2hjbpkf4c0m48945ivxs3lmsczzw2rg-bash-4.4-p23/bin/sh"
/nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8/bin/.a2j_control-wrapped: interpreter directive changed from "/usr/bin/env python" to "/nix/store/irrwwhym6v41phf2707jb8nccf6jzai3-python-2.7.15/bin/python"
checking for references to /build in /nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8...
/nix/store/ij0c7gr3q3sdml9vk89ryiqiqhg8cx0s-a2jmidid-8

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2018

For every other packages it's a no-op.

@markuskowa markuskowa merged commit 2b2b8af into NixOS:master Nov 24, 2018
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2018

Thanks @markuskowa

@c0bw3b c0bw3b deleted the cleanup/repo.or.cz branch November 24, 2018 19:27
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 24, 2018

Related: #13809

@c0bw3b c0bw3b mentioned this pull request Dec 1, 2018
Merged
10 tasks
@infinisil infinisil mentioned this pull request Apr 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @markuskowa