Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: gemsets didn't handle paths correctly #51002

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Bugfix: gemsets didn't handle paths correctly #51002

merged 1 commit into from
Nov 25, 2018
+1 −1

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Nov 25, 2018 •
edited
Loading

Motivation for this change

As I'm returning to a Ruby project, I discovered that gems with a "path" source (important for dev work) would crash nix-shell. This corrects the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nyarly
Bugfix: gemsets didn't handle paths correctly

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a8d6b75
@nyarly nyarly requested a review from zimbatm as a code owner November 25, 2018 00:21
@GrahamcOfBorg GrahamcOfBorg added 6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 25, 2018
@zimbatm zimbatm merged commit 2d5bd33 into NixOS:master Nov 25, 2018
@zimbatm
Copy link
Member

zimbatm commented Nov 25, 2018

thanks!

@nyarly nyarly mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyarly @zimbatm @GrahamcOfBorg