aiohttp: move idna-ssl into propogatedBuildInputs #51010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsam
reviewed
Nov 25, 2018
| propagatedBuildInputs = [ attrs chardet multidict async-timeout yarl ] | ||
| ++ lib.optional (pythonOlder "3.7") idna-ssl; | ||
| propagatedBuildInputs = [ attrs chardet multidict async-timeout yarl idna-ssl ]; | ||
| #++ lib.optional (pythonOlder "3.7") idna-ssl; |
There was a problem hiding this comment.
This line correspond to aiohttp 3.4.4 setup.py idna-ssl>=1.0; python_version<"3.7".
appdaemon is failing because depend on aiohttp 2.3.10 which has idna-ssl>=1.0.0. I'm inclined to fix it in appdaemon expression
diff --git i/pkgs/servers/home-assistant/appdaemon.nix w/pkgs/servers/home-assistant/appdaemon.nix
index b3df4a481cd..8f865f11db6 100644
--- i/pkgs/servers/home-assistant/appdaemon.nix
+++ w/pkgs/servers/home-assistant/appdaemon.nix
@@ -10,6 +10,7 @@ let
inherit version;
sha256 = "8adda6583ba438a4c70693374e10b60168663ffa6564c5c75d3c7a9055290964";
};
+ propagatedBuildInputs = oldAttrs.propagatedBuildInputs ++ [ super.idna-ssl ];
});
yarl = super.yarl.overridePythonAttrs (oldAttrs: rec {
|
See https://github.com/aio-libs/aiohttp/blob/0c54bef942a076ba4bee5b66e9ba5ba33b7a6176/setup.py#L94 for why it was included for Python<3.7 only. |
|
@dotlambda Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #51009
I have no idea what the side effects may be of this change, but it does seem to solve the issue. If I need to do more testing, or my commit format is not correct, please let me know.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)