Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sage refactor #50998

Merged
merged 6 commits into from
Nov 24, 2018
Merged

Sage refactor #50998

merged 6 commits into from
Nov 24, 2018
+236 −375

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 24, 2018

Motivation for this change
  • cleanup the sage package
  • make it more clear which file is responsible for what, improve naming
  • make tests accessible for debugging
  • other misc changes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timokau
sage: drop unused patches
ca6475b
@timokau
sage: drop known-padics-failure patch
9b4a518 
The failure was not observed for a while and is probably fixed now.
@timokau
Copy link
Member Author

timokau commented Nov 24, 2018

@GrahamcOfBorg build "sage.tests.override { longTests = false; }"

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: "sage.tests.override, {, longTests, =, false;, }"

Partial log (click to expand)


Cannot nix-instantiate `=' because:
error: attribute '=' in selection path '=' not found

Cannot nix-instantiate `false;' because:
error: attribute 'false;' in selection path 'false;' not found

Cannot nix-instantiate `}"' because:
error: missing closing quote in selection path '}"'

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: "sage.tests.override, {, longTests, =, false;, }"

Partial log (click to expand)


Cannot nix-instantiate `=' because:
error: attribute '=' in selection path '=' not found

Cannot nix-instantiate `false;' because:
error: attribute 'false;' in selection path 'false;' not found

Cannot nix-instantiate `}"' because:
error: missing closing quote in selection path '}"'

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: "sage.tests.override, {, longTests, =, false;, }"

Partial log (click to expand)


Cannot nix-instantiate `=' because:
error: attribute '=' in selection path '=' not found

Cannot nix-instantiate `false;' because:
error: attribute 'false;' in selection path 'false;' not found

Cannot nix-instantiate `}"' because:
error: missing closing quote in selection path '}"'

@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 24, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@timokau
sage: refactor
3832dde
@timokau
sage: remove openblas hack
21f9123 
The pc files have since been included into the openblas package.
@timokau
sage: add some flexibility to the test runner
e28a8ed 
Make it possible to run individual tests. This is very useful while
git-bisecting.
@timokau
sage: don't fix node version
a0723f1
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sage

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@timokau timokau merged commit 0c23fa9 into NixOS:master Nov 24, 2018
@timokau timokau deleted the sage-refactor branch November 24, 2018 22:59
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

 static void mpz_to_ZZ(struct ZZ* output, mpz_srcptr x)
             ^~~~~~~~~
g++ -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/build/cythonized/sage/libs/ntl/ntl_lzz_pContext.o -L/build/sage-src-8.4/lib -L/nix/store/irrwwhym6v41phf2707jb8nccf6jzai3-python-2.7.15/lib -lntl -lgmp -lm -lstdc++ -lpython2.7 -o build/lib.linux-x86_64-2.7/sage/libs/ntl/ntl_lzz_pContext.so -lpari
building of '/nix/store/ji4jkikwdl2723aisakbwijhkkx7av49-python2.7-sagelib-8.4.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/66hhhzs4xhs6n80l0m3avn4ifijpcspb-python-2.7.15-env.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/iwnyn2iyxqk6b3wm80w3r080cviwmim9-sage-env.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xldrgsf9cnvyrwkrnbyhncxyh0dwn6zf-sage-with-env-8.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ab3pzhz8n3c0l63g4yznhiihw7an3053-sage-tests-8.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bxj63ipkgbqz834izspnhiy3d09ngpa1-sage-8.4.drv': 2 dependencies couldn't be built
error: build of '/nix/store/bxj63ipkgbqz834izspnhiy3d09ngpa1-sage-8.4.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: sage

Partial log (click to expand)

    [41 tests, 0.03 s]
sage -t --long /nix/store/fbsf0hqqqj1qj5wxj5mr2n5658f2nzy4-sage-src-8.4/src/sage/misc/sage_input.py
    [735 tests, 0.29 s]
sage -t --long /nix/store/fbsf0hqqqj1qj5wxj5mr2n5658f2nzy4-sage-src-8.4/src/sage/misc/sage_timeit.py
    [44 tests, 1.08 s]
sage -t --long /nix/store/fbsf0hqqqj1qj5wxj5mr2n5658f2nzy4-sage-src-8.4/src/sage/misc/sage_unittest.py
    [88 tests, 0.45 s]
building of '/nix/store/ab3pzhz8n3c0l63g4yznhiihw7an3053-sage-tests-8.4.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/bxj63ipkgbqz834izspnhiy3d09ngpa1-sage-8.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bxj63ipkgbqz834izspnhiy3d09ngpa1-sage-8.4.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg