Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tesseract_4: 4.00.00alpha-git-20170410 -> 4.0.0 #51000

Merged
merged 1 commit into from Nov 29, 2018
Merged

tesseract_4: 4.00.00alpha-git-20170410 -> 4.0.0 #51000

merged 1 commit into from Nov 29, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Nov 24, 2018

The 4.0.0 stable release is out.

Changelog: https://github.com/tesseract-ocr/tesseract/wiki/4.0x-Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tesseract_4

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tesseract_4

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0
shrinking /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0/bin/tesseract
shrinking /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0/lib/libtesseract.so.4.0.0
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0/lib  /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0/bin
patching script interpreter paths in /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0
checking for references to /build in /nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0...
/nix/store/zdi1nbxq4xil1dmajq86n274lzw24lik-tesseract-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tesseract_4

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0
shrinking /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0/lib/libtesseract.so.4.0.0
shrinking /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0/bin/tesseract
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0/lib  /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0/bin
patching script interpreter paths in /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0
checking for references to /build in /nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0...
/nix/store/85y94l3rzim9943kwp9yli9vqi95wasy-tesseract-4.0.0

Ma27
Ma27 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested locally (also with pytesseract integration).
As all supported systems pass on Borg this should be a safe thing to do 👍

@Ma27 Ma27 merged commit f211bad into NixOS:master Nov 29, 2018
@ryantm ryantm deleted the tesseract branch November 29, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryantm @GrahamcOfBorg @Ma27