Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treewide: use more HTTPS-enabled sources #51001

Merged
merged 12 commits into from Nov 25, 2018
Merged

Treewide: use more HTTPS-enabled sources #51001

merged 12 commits into from Nov 25, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 24, 2018

Motivation for this change

More usage of HTTPS-enabled upstream sources :

Related: #13809

/cc @markuskowa @infinisil @ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libmatheval, super, tiptop

Partial log (click to expand)

these paths will be fetched (0.13 MiB download, 0.93 MiB unpacked):
  /nix/store/2rk45njmykpz8q663zl69ridwyjis6xd-super-3.30.0
  /nix/store/ng501mdmzpf798cm9ma6gzs6hncd96ij-tiptop-2.3.1
  /nix/store/qwmhfjzm7svj9nag7r0j8x33mqmgzsf8-libmatheval-1.1.11
copying path '/nix/store/qwmhfjzm7svj9nag7r0j8x33mqmgzsf8-libmatheval-1.1.11' from 'https://cache.nixos.org'...
copying path '/nix/store/2rk45njmykpz8q663zl69ridwyjis6xd-super-3.30.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ng501mdmzpf798cm9ma6gzs6hncd96ij-tiptop-2.3.1' from 'https://cache.nixos.org'...
/nix/store/qwmhfjzm7svj9nag7r0j8x33mqmgzsf8-libmatheval-1.1.11
/nix/store/2rk45njmykpz8q663zl69ridwyjis6xd-super-3.30.0
/nix/store/ng501mdmzpf798cm9ma6gzs6hncd96ij-tiptop-2.3.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libmatheval, super, tiptop

Partial log (click to expand)

these paths will be fetched (0.15 MiB download, 0.96 MiB unpacked):
  /nix/store/c0vd47wnvlarbxd1mjj8vjca4mhlzw0j-tiptop-2.3.1
  /nix/store/h1dy883b8r1ca9fpckqnyn956k8ns6bj-libmatheval-1.1.11
  /nix/store/sbqcwnja4fndwm3mphwc9p1v7dbav2k8-super-3.30.0
copying path '/nix/store/h1dy883b8r1ca9fpckqnyn956k8ns6bj-libmatheval-1.1.11' from 'https://cache.nixos.org'...
copying path '/nix/store/sbqcwnja4fndwm3mphwc9p1v7dbav2k8-super-3.30.0' from 'https://cache.nixos.org'...
copying path '/nix/store/c0vd47wnvlarbxd1mjj8vjca4mhlzw0j-tiptop-2.3.1' from 'https://cache.nixos.org'...
/nix/store/h1dy883b8r1ca9fpckqnyn956k8ns6bj-libmatheval-1.1.11
/nix/store/sbqcwnja4fndwm3mphwc9p1v7dbav2k8-super-3.30.0
/nix/store/c0vd47wnvlarbxd1mjj8vjca4mhlzw0j-tiptop-2.3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libmatheval, super, tiptop, win-spice

Partial log (click to expand)

  /nix/store/sszxx6icsg6hlb30mlcigmqrb0sjrhv1-win-spice-0.11
copying path '/nix/store/sszxx6icsg6hlb30mlcigmqrb0sjrhv1-win-spice-0.11' from 'https://cache.nixos.org'...
copying path '/nix/store/2rk45njmykpz8q663zl69ridwyjis6xd-super-3.30.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ng501mdmzpf798cm9ma6gzs6hncd96ij-tiptop-2.3.1' from 'https://cache.nixos.org'...
copying path '/nix/store/hvfxnbq03g3cm8czx6qn1hgs2arxas2j-flex-2.6.4' from 'https://cache.nixos.org'...
copying path '/nix/store/qwmhfjzm7svj9nag7r0j8x33mqmgzsf8-libmatheval-1.1.11' from 'https://cache.nixos.org'...
/nix/store/qwmhfjzm7svj9nag7r0j8x33mqmgzsf8-libmatheval-1.1.11
/nix/store/2rk45njmykpz8q663zl69ridwyjis6xd-super-3.30.0
/nix/store/ng501mdmzpf798cm9ma6gzs6hncd96ij-tiptop-2.3.1
/nix/store/sszxx6icsg6hlb30mlcigmqrb0sjrhv1-win-spice-0.11

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libmatheval, super, tiptop, win-spice

Partial log (click to expand)

these paths will be fetched (7.48 MiB download, 27.61 MiB unpacked):
  /nix/store/fxdq8dzgd5yds88n3l2mv18kwkwk0291-win-spice-0.11
copying path '/nix/store/fxdq8dzgd5yds88n3l2mv18kwkwk0291-win-spice-0.11' from 'https://cache.nixos.org'...
/nix/store/h1dy883b8r1ca9fpckqnyn956k8ns6bj-libmatheval-1.1.11
/nix/store/sbqcwnja4fndwm3mphwc9p1v7dbav2k8-super-3.30.0
/nix/store/c0vd47wnvlarbxd1mjj8vjca4mhlzw0j-tiptop-2.3.1
/nix/store/fxdq8dzgd5yds88n3l2mv18kwkwk0291-win-spice-0.11

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 25, 2018

Ok I'm merging before I have to resolve conflicts :)

@c0bw3b c0bw3b merged commit 6a5fff3 into NixOS:master Nov 25, 2018
@c0bw3b c0bw3b deleted the cleanup/more-https branch November 25, 2018 16:38
@infinisil infinisil mentioned this pull request Apr 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @GrahamcOfBorg @markuskowa