Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nghttp2: 1.34.0 -> 1.35.0 #50978

Merged
merged 1 commit into from Nov 27, 2018
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 24, 2018

Motivation for this change

https://nghttp2.org/blog/2018/11/23/nghttp2-v1-35-0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/kbc7wx4m6kipjkywq7890p3dnrfvvdvj-nghttp2-1.35.0-dev/lib
patching script interpreter paths in /nix/store/kbc7wx4m6kipjkywq7890p3dnrfvvdvj-nghttp2-1.35.0-dev
checking for references to /build/ in /nix/store/kbc7wx4m6kipjkywq7890p3dnrfvvdvj-nghttp2-1.35.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/6gc463lgqp95hy2pnyydkpr3imazs269-nghttp2-1.35.0-lib
shrinking /nix/store/6gc463lgqp95hy2pnyydkpr3imazs269-nghttp2-1.35.0-lib/lib/libnghttp2.so.14.17.1
strip is /nix/store/yyx28sl7a9n4xs9f82v0llpvrmryanan-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6gc463lgqp95hy2pnyydkpr3imazs269-nghttp2-1.35.0-lib/lib
patching script interpreter paths in /nix/store/6gc463lgqp95hy2pnyydkpr3imazs269-nghttp2-1.35.0-lib
checking for references to /build/ in /nix/store/6gc463lgqp95hy2pnyydkpr3imazs269-nghttp2-1.35.0-lib...
/nix/store/vifbwfz78j0825b1xbpk2aixzgba9dn3-nghttp2-1.35.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

strip is /nix/store/br51frm28n8n85bs9wrcx6g8rpa42ain-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qg5pkd21j3mzp34a26xb23yhrjgg2i5w-nghttp2-1.35.0-dev/lib
patching script interpreter paths in /nix/store/qg5pkd21j3mzp34a26xb23yhrjgg2i5w-nghttp2-1.35.0-dev
checking for references to /build/ in /nix/store/qg5pkd21j3mzp34a26xb23yhrjgg2i5w-nghttp2-1.35.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/bsfh4bzxxaq5fz0ddxzvd1dkgddlz5yv-nghttp2-1.35.0-lib
shrinking /nix/store/bsfh4bzxxaq5fz0ddxzvd1dkgddlz5yv-nghttp2-1.35.0-lib/lib/libnghttp2.so.14.17.1
strip is /nix/store/br51frm28n8n85bs9wrcx6g8rpa42ain-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bsfh4bzxxaq5fz0ddxzvd1dkgddlz5yv-nghttp2-1.35.0-lib/lib
patching script interpreter paths in /nix/store/bsfh4bzxxaq5fz0ddxzvd1dkgddlz5yv-nghttp2-1.35.0-lib
checking for references to /build/ in /nix/store/bsfh4bzxxaq5fz0ddxzvd1dkgddlz5yv-nghttp2-1.35.0-lib...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: nghttp2

Partial log (click to expand)

strip is /nix/store/2ws9cmamvr7xyvdg4d2nnd1bmr1zjrrq-bootstrap-tools/bin/strip
patching script interpreter paths in /nix/store/ir59rqmyzvbhas3dwyfi3yhc58dws1nn-swift-corefoundation
cannot build derivation '/nix/store/fw14vh27ia8bjd10mnmlacizw44ak55c-stdenv-darwin.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/sqy375bq6g2frm6vlzizv9gg6yl00lpc-c-ares-1.15.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c5g9wbhs42adh0iqlijy5v4dsc3bg0gw-libev-4.24.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zhr26mflrz29s270ai45wn8wnzb1m3dk-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/cl0wrs3s7gaf1l0h631c9rbd5y5ksk8y-pkg-config-0.29.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x71yy96x3ya42y2nm0rjhykxaq0gci3a-openssl-1.0.2q.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vqw4nw662pxvqy2lf5vlfh2ijpdkvnii-nghttp2-1.35.0.drv': 5 dependencies couldn't be built
error: build of '/nix/store/vqw4nw662pxvqy2lf5vlfh2ijpdkvnii-nghttp2-1.35.0.drv' failed

@dtzWill dtzWill merged commit d0ed3e5 into NixOS:staging Nov 27, 2018
@dtzWill dtzWill deleted the update/nghttp2-1.35.0 branch November 27, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants