Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multimc: create compatibility symlink to fix desktop icon (18.03) #42847

Merged
merged 2 commits into from
Jul 3, 2018
Merged

multimc: create compatibility symlink to fix desktop icon (18.03) #42847

merged 2 commits into from
Jul 3, 2018
+11 −2

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

close #42784 for 18.03
This also includes an update -> 0.6.2 which I thought would be safe to do here also.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Madouura and others added 2 commits July 1, 2018 17:22
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 1, 2018
infinisil
infinisil reviewed Jul 3, 2018
View reviewed changes
pkgs/games/multimc/default.nix
@@ -18,7 +18,16 @@ in stdenv.mkDerivation rec {
enableParallelBuilding = true;

postInstall = ''
mkdir -p $out/share/{applications,pixmaps}
cp ../application/resources/multimc/scalable/multimc.svg $out/share/pixmaps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is $out/share/pixmaps for? Am curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff for like apps like this with pixmaps... with java? Idk 😂

@infinisil
Copy link
Member

@GrahamcOfBorg build multimc

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: multimc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: multimc

Partial log (click to expand)

shrinking /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2/bin/libMultiMC_logic.so
shrinking /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2/bin/libMultiMC_gui.so
shrinking /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2/bin/.MultiMC-wrapped
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2/bin
patching script interpreter paths in /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2
/nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2/MultiMC: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2...
postPatchMkspecs
/nix/store/rrcac7d2nhin7ich1iq8sfim3z7p2n2f-multimc-0.6.2

@infinisil
Copy link
Member

This is weird.. Why did it succeed on x86, but fail with the unfree message on aarch..

@samueldr
Copy link
Member

samueldr commented Jul 3, 2018 

Package ‘oraclejdk-8u171’ in /var/lib/gc-of-borg/nix-test-rs-26/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-26/pkgs/development/compilers/oraclejdk/jdk-linux-base.nix:71 has an unfree license (‘unfree’), refusing to evaluate.

The JDK used @infinisil

@infinisil
Copy link
Member

Ah right, will check the logs next time. Didn't realize that it's possible to have different derivations depending on the arch.

@infinisil infinisil merged commit 244c2db into NixOS:release-18.03 Jul 3, 2018
@worldofpeace worldofpeace deleted the multimc-picked branch July 3, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @infinisil @GrahamcOfBorg @samueldr @Madouura