yabar: fix build #42346
Merged
yabar: fix build #42346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stable build for `yabar` is currently broken: https://hydra.nixos.org/build/75989172 Main reason is that the inline function `ya_setup_prefix_suffix` is supposed to be an inline function, but was insufficiently declared as such which broke the compiler recently with the following message: ``` gcc -std=c99 -Iinclude -pedantic -Wall -Os `pkg-config --cflags pango pangocairo libconfig` -DVERSION=\"0.4.0\" -D_POSIX_C_SOURCE=199309L -DYA_INTERNAL -DYA_DYN_COL -DYA_ENV_VARS -DYA_INTERNAL_EWMH -c -o src/intern_blks/ya_intern.o src/intern_blks/ya_intern.c gcc -o yabar src/ya_main.o src/ya_draw.o src/ya_exec.o src/ya_parse.o src/intern_blks/ya_intern.o -lxcb -lpthread -lxcb-randr -lxcb-ewmh `pkg-config --libs pango pangocairo libconfig` src/intern_blks/ya_intern.o: In function `ya_int_date': ya_intern.c:(.text+0x49): undefined reference to `ya_setup_prefix_suffix' src/intern_blks/ya_intern.o: In function `ya_int_uptime': ya_intern.c:(.text+0xf4): undefined reference to `ya_setup_prefix_suffix' src/intern_blks/ya_intern.o: In function `ya_int_brightness': ya_intern.c:(.text+0x1d8): undefined reference to `ya_setup_prefix_suffix' src/intern_blks/ya_intern.o: In function `ya_int_bandwidth': ya_intern.c:(.text+0x377): undefined reference to `ya_setup_prefix_suffix' src/intern_blks/ya_intern.o: In function `ya_int_cpu': ya_intern.c:(.text+0x6de): undefined reference to `ya_setup_prefix_suffix' src/intern_blks/ya_intern.o:ya_intern.c:(.text+0x924): more undefined references to `ya_setup_prefix_suffix' follow collect2: error: ld returned 1 exit status make: *** [Makefile:18: yabar] Error 1 ``` This issue has been fixed on master (see geommer/yabar@9779a5e) which is why `nixos.yabar-unstable` remained functional.
|
Success on aarch64-linux (full log) Attempted: yabar Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: yabar Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The stable build for
yabaris currently broken: https://hydra.nixos.org/build/75989172Main reason is that the inline function
ya_setup_prefix_suffixissupposed to be an inline function, but was insufficiently declared as
such which broke the compiler recently with the following message:
This issue has been fixed on master (see
geommer/yabar@9779a5e)
which is why
nixos.yabar-unstableremained functional.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)