Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.thumbor: 6.4.2 -> 6.5.1 #42350

Merged
merged 1 commit into from Jun 22, 2018
Merged

pythonPackages.thumbor: 6.4.2 -> 6.5.1 #42350

merged 1 commit into from Jun 22, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 21, 2018 •
edited

Motivation for this change

The current thumbor build on master: https://hydra.nixos.org/build/76000076

This is mainly caused by several dependency bumps (e.g.
pythonPackages.tornado to v5 in dd936cc)
that broke the setup.py from version 6.4.

Bumping to the latest stable version (6.5.1) fixes these issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.thumbor: 6.4.2 -> 6.5.1
4239726 
The current `thumbor` build on master: https://hydra.nixos.org/build/76000076

This is mainly caused by several dependency bumps (e.g.
`pythonPackages.tornado` to v5 in dd936cc)
that broke the `setup.py` from version 6.4.

Bumping to the latest stable version (6.5.1) fixes these issues.
@Ma27 Ma27 requested a review from FRidh as a code owner June 21, 2018 22:07
@Ma27
Copy link
Member Author

Ma27 commented Jun 21, 2018 •
edited

nox-review is still in progress and it seems to take a while locally, I'll update the PR as soon as its ready %)

EDIT: nox-review seems fine:

lrwxrwxrwx 1 ma27 users 67 Jun 22 00:27 result -> /nix/store/hcbb7hrf25s6w9lqjbfg863rfhfhylcz-python2.7-thumbor-6.5.1
lrwxrwxrwx 1 ma27 users 75 Jun 22 00:27 result-2 -> /nix/store/839g2pd0h2x4lhdbrf73109k3yhbxvn7-gwyddion-18.09.git.136f1c47066M
lrwxrwxrwx 1 ma27 users 73 Jun 22 00:27 result-3 -> /nix/store/18qvak7x67whijkbhk5fpdwjf41smrk6-ripser-18.09.git.136f1c47066M
lrwxrwxrwx 1 ma27 users 57 Jun 22 00:27 result-4 -> /nix/store/2vnh08v8znar6lzc0qb4snavmk8zxrzc-osquery-3.2.8

@FRidh FRidh merged commit b748777 into NixOS:master Jun 22, 2018
@Ma27 Ma27 deleted the fix-py-thumbor branch June 22, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @FRidh @GrahamcOfBorg