Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.git-annex-adapter: fix build #42345

Merged
merged 1 commit into from Jun 23, 2018
Merged

python3Packages.git-annex-adapter: fix build #42345

merged 1 commit into from Jun 23, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 21, 2018 •
edited

Motivation for this change

The exception message is broken becuase of some uppercase vs. lowercase
issues that have been patched accordingly.

Additionally use fetchpatch rather than fetchurl to apply patches
into the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner June 21, 2018 21:15
FRidh
FRidh reviewed Jun 22, 2018
View reviewed changes
pkgs/development/python-modules/git-annex-adapter/default.nix Outdated
./not-a-git-repo-testcase.patch
(fetchpatch {
url = "https://github.com/alpernebbi/git-annex-adapter/commit/9f64c4b99cae7b681820c6c7382e1e40489f4d1e.patch";
sha256 = "1hbw8651amjskakvs1wv2msd1wryrq0vpryvbispg5267rs8q7hp";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sha256 will be different

@Ma27
python3Packages.git-annex-adapter: fix build
47558d9 
The exception message is broken becuase of some uppercase vs. lowercase
issues that have been patched accordingly.

Additionally use `fetchpatch` rather than `fetchurl` to apply patches
into the build.
@Ma27 Ma27 force-pushed the fix-python-git-annex-adapter branch from a491de8 to 47558d9 Compare June 22, 2018 08:19
@Ma27
Copy link
Member Author

Ma27 commented Jun 22, 2018

@FRidh dammit, thanks :D

@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

@GrahamcOfBorg build python3Packages.git-annex-adapter

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.git-annex-adapter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.git-annex-adapter

Partial log (click to expand)

./nix/store/pz8nl4cnppd3p1cykshcb40mqxjd5yvy-python3-3.6.5/lib/python3.6/subprocess.py:766: ResourceWarning: subprocess 1767 is still running
  ResourceWarning, source=self)
./nix/store/pz8nl4cnppd3p1cykshcb40mqxjd5yvy-python3-3.6.5/lib/python3.6/subprocess.py:766: ResourceWarning: subprocess 1954 is still running
  ResourceWarning, source=self)
................
----------------------------------------------------------------------
Ran 27 tests in 2.752s

OK
/nix/store/jp3lnqz8rfqwiw8s57kkxqpjs905439b-python3.6-git-annex-adapter-0.2.0

@FRidh FRidh merged commit 4352048 into NixOS:master Jun 23, 2018
@Ma27 Ma27 deleted the fix-python-git-annex-adapter branch June 23, 2018 16:05
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python3Packages.git-annex-adapter

Partial log (click to expand)

patching script interpreter paths in /nix/store/zxbqqy2h13fwgmk8dns4r69kmmr83xqy-zip-archive-0.3.2.5
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ssc292z3phz326yky2dzr129pf9zcg2h-zip-archive-0.3.2.5-doc
cannot build derivation '/nix/store/40klwmlaga0cv78jiwix9ic23ws4riqk-pandoc-2.1.2.drv': 4 dependencies couldn't be built
building '/nix/store/3l3rxplf34fr5fvxnkvha0d7ig1hvdwy-utillinux-compat-1003.1-2008.drv'...
cannot build derivation '/nix/store/2zabn04m00inivdpxj81cqvwk9hlw8i9-bup-0.29.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r2waz58pi2mjzsv5chnqjfn2jbz3fn5i-git-annex-6.20180529.drv': 35 dependencies couldn't be built
created 10 symlinks in user environment
cannot build derivation '/nix/store/ynbwpy0rghxzmfjz24980cnkk2ajq9nx-python3.6-git-annex-adapter-0.2.0.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/ynbwpy0rghxzmfjz24980cnkk2ajq9nx-python3.6-git-annex-adapter-0.2.0.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @FRidh @GrahamcOfBorg