Fixed broken link rendering for external links at start of line #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only comment, are we sure that '/' is the only character that disallows simple urls? Off the top of my head, no testing, paths with '\' ? Other than that, 👍 |
|
@LarsGit223 you tagged this with needs improvement. Can you explain what needs to be done here? |
|
@splitbrain: @ssahara suggested an adjustment of the pattern, see end of the discussion at #2399 I wanted to apply that change and eventually add more test cases (if missing, e.g. for a link in round parenthesis) |
|
@splitbrain: looks ok to me now. Travis CI build failures are not caused by my changes. |
External links at the start of line like 'www.example.com' were not rendered as links any more. The issue was introduced with PR #1988. Fixes #2399.
|
Is this fine to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External links at the start of line like
www.example.comwere not rendered as links any more. The issue was introduced with PR #1988. Fixes #2399.