Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1.26.2 -> 1.27.0 #42348

Closed
wants to merge 1 commit into from
Closed

rustc: 1.26.2 -> 1.27.0 #42348

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 21, 2018 •
edited

Motivation for this change

testing & building is work in progress.

changelog: https://blog.rust-lang.org/2018/06/21/Rust-1.27.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from LnL7 as a code owner June 21, 2018 21:48
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rustc

Partial log (click to expand)

applying patch /nix/store/fn8kr2ybfkaakdsc0vhzpvi31m3wq6js-net-tcp-disable-tests.patch
patching file src/libstd/net/tcp.rs
Hunk #8 succeeded at 1518 (offset 90 lines).
applying patch /nix/store/bfk7gzpbnm5lndagwmvnv6ymg00vq0yx-stdsimd-disable-doctest.patch
patching file src/stdsimd/coresimd/x86/mod.rs
Hunk #1 FAILED at 279.
Hunk #2 FAILED at 301.
2 out of 2 hunks FAILED -- saving rejects to file src/stdsimd/coresimd/x86/mod.rs.rej
builder for '/nix/store/y2z1qx4cs11ibsj62k6gi92zzacg80sc-rustc-1.27.0.drv' failed with exit code 1
error: build of '/nix/store/y2z1qx4cs11ibsj62k6gi92zzacg80sc-rustc-1.27.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: rustc

Partial log (click to expand)

applying patch /nix/store/fn8kr2ybfkaakdsc0vhzpvi31m3wq6js-net-tcp-disable-tests.patch
patching file src/libstd/net/tcp.rs
Hunk #8 succeeded at 1518 (offset 90 lines).
applying patch /nix/store/bfk7gzpbnm5lndagwmvnv6ymg00vq0yx-stdsimd-disable-doctest.patch
patching file src/stdsimd/coresimd/x86/mod.rs
Hunk #1 FAILED at 279.
Hunk #2 FAILED at 301.
2 out of 2 hunks FAILED -- saving rejects to file src/stdsimd/coresimd/x86/mod.rs.rej
builder for '/nix/store/qqmdkjk09qsi0p62r0lqkb8y4xyr8q98-rustc-1.27.0.drv' failed with exit code 1
error: build of '/nix/store/qqmdkjk09qsi0p62r0lqkb8y4xyr8q98-rustc-1.27.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: rustc

Partial log (click to expand)

applying patch /nix/store/fn8kr2ybfkaakdsc0vhzpvi31m3wq6js-net-tcp-disable-tests.patch
patching file src/libstd/net/tcp.rs
Hunk #8 succeeded at 1518 (offset 90 lines).
applying patch /nix/store/bfk7gzpbnm5lndagwmvnv6ymg00vq0yx-stdsimd-disable-doctest.patch
patching file src/stdsimd/coresimd/x86/mod.rs
Hunk #1 FAILED at 279.
Hunk #2 FAILED at 301.
2 out of 2 hunks FAILED -- saving rejects to file src/stdsimd/coresimd/x86/mod.rs.rej
builder for '/nix/store/v5wrrvvax1ad3zncy6688ymwyc2cfr6v-rustc-1.27.0.drv' failed with exit code 1
error: build of '/nix/store/v5wrrvvax1ad3zncy6688ymwyc2cfr6v-rustc-1.27.0.drv' failed

Mic92
Mic92 commented Jun 21, 2018
View reviewed changes
pkgs/development/compilers/rust/default.nix
./patches/stdsimd-disable-doctest.patch

# Re-evaluate if this we need to disable this one
#./patches/stdsimd-disable-doctest.patch
Copy link
Member Author

@Mic92 Mic92 Jun 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LnL7 I suppose those will still fail on macOS, can you check this? If this is the case, we need to expand the existing patch, since it now contains more examples.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rustc

Partial log (click to expand)

Cannot nix-instantiate `rustc' because:
�[31;1merror:�[0m access to path '/private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/default.nix' is forbidden in restricted mode

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: rustc

Partial log (click to expand)

[ 70%] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64Subtarget.cpp.o
[ 70%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ThumbRegisterInfo.cpp.o
[ 70%] Building CXX object lib/Target/Mips/CMakeFiles/LLVMMipsCodeGen.dir/MipsOptimizePICCall.cpp.o
[ 70%] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/AArch64TargetMachine.cpp.o
[ 70%] Building CXX object lib/Target/PowerPC/CMakeFiles/LLVMPowerPCCodeGen.dir/PPCISelLowering.cpp.o
[ 70%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/Thumb2ITBlockPass.cpp.o
[ 70%] Building CXX object lib/Target/Mips/CMakeFiles/LLVMMipsCodeGen.dir/MipsOs16.cpp.o
[ 70%] Building CXX object lib/Target/Mips/CMakeFiles/LLVMMipsCodeGen.dir/MipsRegisterInfo.cpp.o
building of '/nix/store/5bm7kg8zf8vma77dpz2ii32kq00wy09b-rustc-1.27.0.drv' timed out after 1800 seconds
error: build of '/nix/store/5bm7kg8zf8vma77dpz2ii32kq00wy09b-rustc-1.27.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: rustc

Partial log (click to expand)

   Compiling syntax_pos v0.0.0 (file:///build/rustc-1.27.0-src/src/libsyntax_pos)
   Compiling arena v0.0.0 (file:///build/rustc-1.27.0-src/src/libarena)
   Compiling rls-span v0.4.0
   Compiling rls-data v0.15.0
   Compiling rustc_errors v0.0.0 (file:///build/rustc-1.27.0-src/src/librustc_errors)
   Compiling backtrace v0.3.6
   Compiling proc_macro v0.0.0 (file:///build/rustc-1.27.0-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.27.0-src/src/libsyntax_ext)
building of '/nix/store/84aibn4kyds9av1y64xjdcyzvisna7pl-rustc-1.27.0.drv' timed out after 3600 seconds
error: build of '/nix/store/84aibn4kyds9av1y64xjdcyzvisna7pl-rustc-1.27.0.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Jun 22, 2018

still need some work:

> Bootstrap
running: "/nix/store/5grn0alv350ymxvjjn92lf5cr2d3gq3j-rustc-bootstrap-1.26.2/bin/cargo" "test" "--"
   Compiling ansi_term v0.11.0
   Compiling difference v2.0.0
   Compiling pretty_assertions v0.5.1
   Compiling bootstrap v0.0.0 (file:///tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/src/bootstrap)
    Finished dev [unoptimized] target(s) in 25.3 secs
     Running /tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/build/bootstrap/debug/deps/bootstrap-1d38a3d59be9ff01
running 9 tests
error: test failed, to rerun pass '--lib'
command did not execute successfully: "/nix/store/5grn0alv350ymxvjjn92lf5cr2d3gq3j-rustc-bootstrap-1.26.2/bin/cargo" "test" "--"
expected success, got: exit code: 1
Traceback (most recent call last):
  File "/tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/src/bootstrap/bootstrap.py", line 817, in <module>
    main()
  File "/tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/src/bootstrap/bootstrap.py", line 800, in main
    bootstrap(help_triggered)
  File "/tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/src/bootstrap/bootstrap.py", line 791, in bootstrap
    run(args, env=env, verbose=build.verbose)
  File "/tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/src/bootstrap/bootstrap.py", line 148, in run
    raise RuntimeError(err)
RuntimeError: failed to run: /tmp/nix-build-rustc-1.27.0.drv-2/rustc-1.27.0-src/build/bootstrap/debug/bootstrap test --jobs 1 -v
make: *** [Makefile:58: check] Error 1
builder for '/nix/store/5bm7kg8zf8vma77dpz2ii32kq00wy09b-rustc-1.27.0.drv' failed with exit code 2
error: build of '/nix/store/5bm7kg8zf8vma77dpz2ii32kq00wy09b-rustc-1.27.0.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Jun 22, 2018 •
edited

The aarch64 build is fine.

@LnL7
Copy link
Member

LnL7 commented Jun 22, 2018

Same error on x86_64-darwin.

@edolstra
Copy link
Member

edolstra commented Jul 3, 2018

The test is failing because it's trying to run the stage-0 bootstrap compiler from a path that doesn't exist:

pid 22373] execve("/tmp/nix-build-rustc-1.27.0.drv-0/rustc-1.27.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/rustc", ["/tmp/nix-build-rustc-1.27.0.drv-0/rustc-1.27.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/rustc", "--version", "--verbose"], 0x7ffce28b5dc8 /* 186 vars */) = -1 ENOENT (No such file or directory)

build/x86_64-unknown-linux-gnu/stage0/bin/rustc does not exist. However, ./build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/rustc does exist.

@edolstra
Copy link
Member

edolstra commented Jul 9, 2018

I've disabled the tests for now (323fe3a). If somebody wants to spend a few hours debugging the rust build process, you're welcome ;-)

@edolstra edolstra closed this Jul 9, 2018
@Mic92 Mic92 deleted the rustc branch September 14, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: rust 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @LnL7 @edolstra