Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ldap3: 2.4.1 -> 2.5 #42338

Closed
wants to merge 1 commit into from
Closed

pythonPackages.ldap3: 2.4.1 -> 2.5 #42338

wants to merge 1 commit into from

Conversation

thanegill
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@thanegill thanegill requested a review from FRidh as a code owner June 21, 2018 18:27
@lsix
Copy link
Member

lsix commented Jun 22, 2018

Changelog: http://ldap3.readthedocs.io/changelog.html

nox-review pr 42338 fails only on mitmproxy (which also fails on master).

Looks good to me.

@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

This has landed in master (5273641).

@FRidh FRidh closed this Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thanegill @lsix @FRidh @GrahamcOfBorg