Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-authenticator-failed-to-use-libqrencode - use libqrencode 4 #42337

Merged
merged 1 commit into from Jun 29, 2018
Merged

google-authenticator-failed-to-use-libqrencode - use libqrencode 4 #42337

merged 1 commit into from Jun 29, 2018

Conversation

ookhoi
Copy link
Contributor

@ookhoi ookhoi commented Jun 21, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ookhoi
Copy link
Contributor Author

ookhoi commented Jun 21, 2018

This commit makes google-authenticator generates a QR code on the terminal again, and enables me to ssh into my NixOS with 2FA.

@ookhoi ookhoi mentioned this pull request Jun 21, 2018
Merged
9 tasks
@ookhoi
Copy link
Contributor Author

ookhoi commented Jun 28, 2018

can this pr be merged?

@matthewbauer matthewbauer merged commit 3d20d59 into NixOS:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ookhoi @matthewbauer @GrahamcOfBorg