Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamlink: 0.12.1 -> 0.13.0 #42336

Merged
merged 1 commit into from Jun 24, 2018
Merged

streamlink: 0.12.1 -> 0.13.0 #42336

merged 1 commit into from Jun 24, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @dezgeg @zraexy

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build streamlink

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

TypeError: freeze_time() expected None, a string, date instance, or datetime instance, but got type <class 'function'>.

----------------------------------------------------------------------
Ran 517 tests in 10.710s

FAILED (errors=1, skipped=20)
Test failed: <unittest.runner.TextTestResult run=517 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=517 errors=1 failures=0>
builder for '/nix/store/fr0ly6d31vhapk646ryr6kyyddqqm223-streamlink-0.13.0.drv' failed with exit code 1
error: build of '/nix/store/fr0ly6d31vhapk646ryr6kyyddqqm223-streamlink-0.13.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

TypeError: freeze_time() expected None, a string, date instance, or datetime instance, but got type <class 'function'>.

----------------------------------------------------------------------
Ran 517 tests in 37.284s

FAILED (errors=1, skipped=20)
Test failed: <unittest.runner.TextTestResult run=517 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=517 errors=1 failures=0>
builder for '/nix/store/354il86la0anipfswldfpkx0422dbniy-streamlink-0.13.0.drv' failed with exit code 1
error: build of '/nix/store/354il86la0anipfswldfpkx0422dbniy-streamlink-0.13.0.drv' failed

xeji
xeji suggested changes Jun 24, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix test failure.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: streamlink

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@jfrankenau jfrankenau requested a review from FRidh as a code owner June 24, 2018 20:20
@jfrankenau
Copy link
Member Author

Sorry, don't know how I missed that.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Please make sure you build on your local machine with sandboxing enabled, sometimes tests only fail in a sandbox.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build streamlink

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

test_can_handle_url (tests.test_plugin_viasat.TestPluginViasat) ... ok
test_json_encoding (tests.test_plugin_api_http_session.TestPluginAPIHTTPSession) ... ok
test_json_encoding_override (tests.test_plugin_api_http_session.TestPluginAPIHTTPSession) ... ok
test_read_timeout (tests.test_plugin_api_http_session.TestPluginAPIHTTPSession) ... ok

----------------------------------------------------------------------
Ran 517 tests in 10.479s

OK (skipped=20)
/nix/store/b0g09aisgi8n7s7nw0wi4m170i5a49cq-streamlink-0.13.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

test_stream_open_video_audio (tests.streams.test_dash.TestDASHStream) ... ok
test_stream_open_video_only (tests.streams.test_dash.TestDASHStream) ... ok
test_dynamic_reload (tests.streams.test_dash.TestDASHStreamWorker) ... ok
test_static (tests.streams.test_dash.TestDASHStreamWorker) ... ok

----------------------------------------------------------------------
Ran 517 tests in 36.719s

OK (skipped=20)
/nix/store/i8slsbrss3kfy2awlciqhx7wzh2vi4vy-streamlink-0.13.0

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: streamlink

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@jfrankenau
Copy link
Member Author

jfrankenau commented Jun 24, 2018 •
edited

I have sandboxing enabled. I merely managed to somehow let this commit slip away …

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Thanks. Why does this cause a mass rebuild of pretty much all haskell things now? If this is necessary, you will need to rebase this PR on the staging branch.

@jfrankenau
Copy link
Member Author

Haskell? With nox-review I am seeing primarily Python packages. This is probably caused by the update of freezegun which is a test dependency and thus indirectly used by those packages.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Can you get the streamlink update to work without updating freezegun?

@jfrankenau
Copy link
Member Author

Yes! I have applied a patch from upstream which was commited twelve days ago specifically to make it work with older versions of freezegun.

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

@GrahamcOfBorg build streamlink

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: streamlink

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

test_language_code_us (tests.test_localization.TestLocalizationPyCountry) ... skipped 'pycountry module required to test pycountry Localization'
test_language_compare (tests.test_localization.TestLocalizationPyCountry) ... skipped 'pycountry module required to test pycountry Localization'
test_not_equivalent (tests.test_localization.TestLocalizationPyCountry) ... skipped 'pycountry module required to test pycountry Localization'
test_pycountry (tests.test_localization.TestLocalizationPyCountry) ... skipped 'pycountry module required to test pycountry Localization'
test_can_handle_url (tests.test_plugin_streamme.TestPluginStreamMe) ... ok

----------------------------------------------------------------------
Ran 517 tests in 10.184s

OK (skipped=20)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: streamlink

Partial log (click to expand)

test_stream_open_video_audio (tests.streams.test_dash.TestDASHStream) ... ok
test_stream_open_video_only (tests.streams.test_dash.TestDASHStream) ... ok
test_dynamic_reload (tests.streams.test_dash.TestDASHStreamWorker) ... ok
test_static (tests.streams.test_dash.TestDASHStreamWorker) ... ok

----------------------------------------------------------------------
Ran 517 tests in 38.591s

OK (skipped=20)
/nix/store/k6y06kw1ngq6bb4kb34nv1bz2bxa9c3d-streamlink-0.13.0

@xeji
Copy link
Contributor

xeji commented Jun 24, 2018

Thank you!

@xeji xeji merged commit cd4c5a3 into NixOS:master Jun 24, 2018
@jfrankenau jfrankenau deleted the update-streamlink branch June 25, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @xeji @GrahamcOfBorg