Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add erlang-21.0 #42329

Merged
merged 1 commit into from Jun 21, 2018
Merged

add erlang-21.0 #42329

merged 1 commit into from Jun 21, 2018

Conversation

goertzenator
Copy link
Contributor

Motivation for this change

A new major revision of Erlang OTP was recently released (21).

The PR adds package erlangR21. The default erlang remains as erlangR19. There are no packages that depend on erlangR21 at this moment.

I used this build for some development on erlang_nif-sys. I had no issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Jun 21, 2018

@GrahamcOfBorg build erlangR21

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: erlangR21

Partial log (click to expand)

/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0/lib/erlang/lib/inets-7.0/examples/server_root/cgi-bin/printenv.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0/lib/erlang/lib/inets-7.0/priv/bin/runcgi.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0/lib/erlang/lib/edoc-0.9.3/priv/edoc_generate: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0/lib/erlang/lib/observer-2.8/priv/bin/etop: interpreter directive changed from "/bin/sh " to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0/lib/erlang/lib/observer-2.8/priv/bin/cdv: interpreter directive changed from "/bin/sh " to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0...
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/azal4549a183iw91rhd0zl7zh2gp5qc3-erlang-21.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: erlangR21

Partial log (click to expand)

/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/erts-10.0/bin/erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/erts-10.0/bin/start_erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/erts-10.0/bin/erl: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/inets-7.0/priv/bin/runcgi.sh: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/inets-7.0/examples/server_root/cgi-bin/printenv.sh: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/observer-2.8/priv/bin/cdv: interpreter directive changed from "/bin/sh " to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/observer-2.8/priv/bin/etop: interpreter directive changed from "/bin/sh " to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/edoc-0.9.3/priv/edoc_generate: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0/lib/erlang/lib/mnesia-4.15.4/examples/bench/bench.sh: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/qn0xyf5rs8lf3z7pq121mdwqza2mm04y-erlang-21.0

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: erlangR21

Partial log (click to expand)

 GEN    ../xml/wxGenericDirCtrl.xml
 GEN    ../xml/wxGraphicsBrush.xml
 GEN    ../xml/wxGraphicsContext.xml
 GEN    ../xml/wxGraphicsFont.xml
 GEN    ../xml/wxGraphicsMatrix.xml
 GEN    ../xml/wxGraphicsObject.xml
 GEN    ../xml/wxGraphicsPath.xml
 GEN    ../xml/wxGraphicsPen.xml
building of '/nix/store/an05pvcqld3rbgcd4jifd56cnaycy7pw-erlang-21.0.drv' timed out after 3600 seconds
error: build of '/nix/store/an05pvcqld3rbgcd4jifd56cnaycy7pw-erlang-21.0.drv' failed

@LnL7 LnL7 merged commit 26434c0 into NixOS:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@goertzenator @LnL7 @GrahamcOfBorg