Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserTimingL3] Replace SyntaxError with TypeError. #17208

Merged
merged 1 commit into from Jun 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 6, 2019

The User Timing L3 specification requires TypeErrors to be thrown when
calls to performance.measure() are malformed. The User Timing L2
specification used SyntaxErrors for similar error conditions.

This CL changes our use of SyntaxError to TypeError when L3 conformance
is active.

Bug: 953960
Change-Id: I87bb0717687f4a3b149eaeb6fc190fa9a98d1f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647342
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Auto-Submit: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668488}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

The User Timing L3 specification requires TypeErrors to be thrown when
calls to `performance.measure()` are malformed. The User Timing L2
specification used SyntaxErrors for similar error conditions.

This CL changes our use of SyntaxError to TypeError when L3 conformance
is active.

Bug: 953960
Change-Id: I87bb0717687f4a3b149eaeb6fc190fa9a98d1f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647342
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Auto-Submit: Tom McKee <tommckee@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668488}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants