Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: disable tests on darwin #62836

Merged
merged 1 commit into from Jun 7, 2019
Merged

gpgme: disable tests on darwin #62836

merged 1 commit into from Jun 7, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jun 7, 2019 •
edited

Motivation for this change

Fixes: #60313

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 7, 2019
@ofborg ofborg bot requested review from Fuuzetsu and primeos June 7, 2019 20:20
@veprbl
Copy link
Member Author

veprbl commented Jun 7, 2019

I worked on alternative solution along the lines of:

substituteInPlace tests/gpg/Makefile.am --replace 'GNUPGHOME=$(abs_builddir)' "GNUPGHOME=$TMPDIR"
substituteInPlace tests/gpg/Makefile.am --replace ' ./' ' $(GNUPGHOME)/'
substituteInPlace tests/gpg/Makefile.am --replace ' private-keys-v1.d' ' $(GNUPGHOME)/private-keys-v1.d'
substituteInPlace tests/gpg/Makefile.am --replace 'echo disable-scdaemon' "( echo disable-scdaemon; echo extra-socket $TMPDIR/e; echo browser-socket $TMPDIR/b )"
substituteInPlace tests/json/Makefile.am --replace 'GNUPGHOME=$(abs_builddir)' "GNUPGHOME=$TMPDIR"
substituteInPlace tests/json/Makefile.am --replace ' ./' ' $(GNUPGHOME)/'
substituteInPlace tests/json/Makefile.am --replace ' private-keys-v1.d' ' $(GNUPGHOME)/private-keys-v1.d'
substituteInPlace tests/json/Makefile.am --replace ' openpgp-revocs.d' ' $(GNUPGHOME)/openpgp-revocs.d'
substituteInPlace tests/json/Makefile.am --replace 'echo disable-scdaemon' "( echo disable-scdaemon; echo extra-socket $TMPDIR/e; echo browser-socket $TMPDIR/b )"

Unfortunately putting GNUPGHOME for "gpg" and "json" tests leads to a conflict. There is no room for 2 extra characters in GNUPGHOME to move those into separate directories. The only remaining option is to either fix the tests or implement a cleanup. I'm not ready to pursue either of these options.

@matthewbauer matthewbauer merged commit b0053ae into NixOS:master Jun 7, 2019
@primeos
Copy link
Member

primeos commented Jun 8, 2019

Thanks :)

@veprbl veprbl deleted the pr/gpgme_darwin_fix branch December 1, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gpg build fails on mac os x
3 participants
@veprbl @primeos @matthewbauer