Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helmfile: fix modSha256 #62837

Merged
merged 1 commit into from
Jun 7, 2019
Merged

helmfile: fix modSha256 #62837

merged 1 commit into from
Jun 7, 2019
+2 −4

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 7, 2019 •
edited
Loading

Motivation for this change

Fix #62786 by fixing modSha256. It seems like this was another case where my Darwin setup was acting weird.

Things done

Remove stdenv.isDarwin logic and stdenv argument.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@yurrriq yurrriq force-pushed the update/helmfile branch from 18ebf3c to 0c28645 Compare June 7, 2019 20:12
@yurrriq
helmfile: fix modSha256
7f9a2f0 
It seems like this was another case where my darwin setup was acting weird.
@yurrriq yurrriq force-pushed the update/helmfile branch from 0c28645 to 7f9a2f0 Compare June 7, 2019 20:13
@yurrriq
Copy link
Member Author

yurrriq commented Jun 7, 2019

@GrahamcOfBorg build helmfile

@ofborg ofborg bot requested a review from kalbasit June 7, 2019 20:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 7, 2019
@yurrriq
Copy link
Member Author

yurrriq commented Jun 7, 2019

/cc @nlewo

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build helmfile

@worldofpeace
Copy link
Contributor

Builds on darwin so I guess it's safe to merge.

@worldofpeace worldofpeace merged commit 8acf093 into NixOS:master Jun 7, 2019
@yurrriq
Copy link
Member Author

yurrriq commented Jun 8, 2019 •
edited
Loading

Thanks! Yeah, same here. I'm not sure how I sometimes (temporarily?) end up with weird hashes on darwin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurrriq @worldofpeace