Daemon: warn when an untrusted user cannot override a setting #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, I have personally been hit by this and witnessed several people being equally confused when confronted to the situation. |
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/cant-run-non-sandboxed-builds-on-nixos-18-09/1110/9 |
grahamc
reviewed
Jun 10, 2019
picnoir
force-pushed
the
nin-add-warning-setting-untrusted
branch
from
27ef8fd
to
92832b0
Compare
In a daemon-based Nix setup, some options cannot be overridden by a client unless the client's user is considered trusted. Currently, if an untrusted user tries to override one of those options, we are silently ignoring it. This can be pretty confusing in certain situations. e.g. a user thinks he disabled the sandbox when in reality he did not. We are now sending a warning message letting know the user some options have been ignored. Related to NixOS#1761.
grahamc
force-pushed
the
nin-add-warning-setting-untrusted
branch
from
92832b0
to
9e0f5f8
Compare
|
This is a very trivial diff, but a very cool UX improvement -- merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a daemon-based nix setup, some options cannot be overridden by a
client unless the client's user is considered as trusted.
Currently, if an untrusted user tries to override one of those
options, we are silently ignoring it.
This can be pretty confusing in certain situations.
e.g. a user thinks he disabled the sandbox when in reality he did not.
We are now sending a warning message letting know the user some options
have been ignored.
Related to #1761.