Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clickhouse: enable for darwin #62843

Closed
wants to merge 4 commits into from
Closed

clickhouse: enable for darwin #62843

wants to merge 4 commits into from
+49 −9

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 7, 2019 •
edited
Loading

A draft, because this sits on top of #62335 - direct any attention about the re2 changes to that PR.

Motivation for this change

With a little effort, clickhouse builds and appears to work on darwin.

The main issue is that it wants to be built with gcc (specifically gcc8) rather than clang, and therefore any c++-linked libraries have to be built with gcc too. This is largely achieved through stdenv-overriding, but in the case of boost requires a minor alteration. I think this is worth it, though - because a gcc-built boost is a valid thing a user might have need of.

The package overrides are only conditionally applied where needed, because I didn't want to cause linux builds to require these packages to be built specifically with gcc 8 rather than the default.

Tested on macos 10.13.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jun 7, 2019
risicle and others added 4 commits June 9, 2019 12:31
@risicle
poco: enable for darwin
a3e1bcc
@risicle
cctz: fix for darwin
eeb2569 
only minor tweaks needed
@risicle
boost: fix building with gcc on darwin
0f3c494 
the trick is that both stdenv and buildPackages.stdenv need to be
overridden to get this to work
@risicle
clickhouse: enable building on darwin
5def299 
this requires a couple of patches but also wants to be built with gcc8,
requiring us to ensure c++ libraries we link to are also built similarly.
@risicle risicle force-pushed the ris-clickhouse-darwin-opt branch from a3784b4 to 5def299 Compare June 9, 2019 11:32
@risicle risicle marked this pull request as ready for review June 9, 2019 11:32
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@risicle do you mind rebasing this?

@risicle
Copy link
Contributor Author

risicle commented Aug 12, 2019

Sure, I'll rebase & retest it when I next have access to a darwin machine.

@risicle
Copy link
Contributor Author

risicle commented Aug 16, 2019

Hmm, this might be a bit delayed as it looks like upstream have broken building on macos ClickHouse/ClickHouse#6429

@alexey-milovidov
Copy link

The main issue is that it wants to be built with gcc (specifically gcc8) rather than clang

We support both gcc and clang, but clang generates slightly less efficient code according to our performance test and we use gcc for production builds.

PS. Our production releases has migrated to gcc-9.

@risicle risicle mentioned this pull request Aug 26, 2019
Merged
10 tasks
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@siraben
Copy link
Member

siraben commented Mar 7, 2021

Please resolve the merge conflict.

@risicle
Copy link
Contributor Author

risicle commented Mar 13, 2021

I actually think most of the work I did here has made it in by other means 🎉, so I'm going to close this.

@risicle risicle closed this Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@risicle @mmahut @alexey-milovidov @siraben @ryantm