Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lkl: fix cross #62842

Merged
merged 1 commit into from Jun 9, 2019
Merged

lkl: fix cross #62842

merged 1 commit into from Jun 9, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

I was working on lkl and realized it would be easy to make it cross compile.

Things done

Adds the necessary makeFlags for cross, based on the Linux kernel derivation.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from copumpkin June 7, 2019 22:41
@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jun 7, 2019
@joachifm
Copy link
Contributor

joachifm commented Jun 9, 2019

@GrahamcOfBorg build lkl

@matthewbauer matthewbauer merged commit b22fa4e into NixOS:master Jun 9, 2019
@lopsided98 lopsided98 deleted the lkl-cross branch June 9, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @joachifm @matthewbauer @veprbl