Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnumeric: 1.12.44 -> 1.12.45 #62798

Merged
merged 1 commit into from Jun 13, 2019
Merged

gnumeric: 1.12.44 -> 1.12.45 #62798

merged 1 commit into from Jun 13, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 7, 2019

Motivation for this change

http://www.gnumeric.org/announcements/1.12/gnumeric-1.12.45.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vcunat June 7, 2019 03:29
@vbgl
Copy link
Contributor

vbgl commented Jun 7, 2019

What about also updating goffice to 0.10.45?

gnumeric-1.12.43 used to build on darwin. Has the build failure been reported upstream?

mmahut
mmahut approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • run nix-review without any failures
  • run and tested the binaries on linux

Approved only for linux, as not sure how to solve the darwin problem.

@Ma27
Copy link
Member

Ma27 commented Jun 7, 2019

Buitl and tested locally. But can you have a look at the broken darwin build? :)

vcunat
vcunat approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I added the goffice bump. Darwin: according to Hydra we had a regression in the previous bump already, so I'm not delaying this PR because of that.

@vcunat vcunat merged commit fd21f3f into NixOS:master Jun 13, 2019
vcunat added a commit that referenced this pull request Jun 13, 2019
@vcunat
Merge #62798: gnumeric: 1.12.44 -> 1.12.45
b6e10d7
@vcunat
Copy link
Member

vcunat commented Jun 13, 2019

This bump apparently exchanged one darwin failure for another which I didn't manage to fix.

@vcunat
Copy link
Member

vcunat commented Jun 13, 2019

I'll hope someone upstream knows: https://gitlab.gnome.org/GNOME/gnumeric/issues/402

@Ma27
Copy link
Member

Ma27 commented Jun 13, 2019

@vcunat thanks a lot for looking at this!

@vcunat
Copy link
Member

vcunat commented Jun 14, 2019

Can someone with direct macos access run the build with --keep-failed and attach the resulting config.log to the upstream ticket?

@vcunat
Copy link
Member

vcunat commented Jun 20, 2019

Cross-link: #63555
It seems someone will need to test that locally.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @vbgl @Ma27 @vcunat @mmahut @jtojnar