os-prober: add test and update #62904
Merged
+133
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
Ekleog
approved these changes
Jun 9, 2019
|
|
||
| testScript = '' | ||
| # hack to add the secondary disk | ||
| $machine->{startCommand} = "QEMU_OPTS=\"\$QEMU_OPTS \"${lib.escapeShellArg QEMU_OPTS} ".$machine->{startCommand}; |
There was a problem hiding this comment.
This is sad but would require some relatively large refactoring to be able to cleanly set that from the test file. 👍 for me to merge with the hack for the time being, but maybe add a comment stating that as a todo?
Co-Authored-By: Léo Gaspard <github@leo.gaspard.ninja>
Co-Authored-By: Léo Gaspard <github@leo.gaspard.ninja>
Co-Authored-By: Léo Gaspard <github@leo.gaspard.ninja>
os-prober should be able to probe unmounted filesystems
|
Ofborg appears to be down, merging without a last check-up ofborg run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update, and add a test to check that updates do not introduce regressions.
The update should be a noop (it only touches debian specific files: https://salsa.debian.org/installer-team/os-prober/compare/1.76...1.77)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)