Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.insert-ordered-containers: fix build #62903

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 9, 2019

Motivation for this change

Fix build package haskellPackages.insert-ordered-containers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin requested a review from basvandijk as a code owner June 9, 2019 17:22
@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 9, 2019

@GrahamcOfBorg build haskellPackages.insert-ordered-containers

@teto
Copy link
Member

teto commented Jun 10, 2019

tested on my customized nixos-unstable (168d103) but I get this :

unpacking source archive /nix/store/jrvhviygv1is89b7icqpsbbdf906acp3-jsprim-1.4.1.tgz
applying patch /nix/store/wwrwknavn8zmss326gq4hf4wxdgijwpj-insert-ordered-containers-fix-test.patch
patching file insert-ordered-containers.cabal
Hunk #1 FAILED at 21.
Hunk #2 FAILED at 70.
2 out of 2 hunks FAILED -- saving rejects to file insert-ordered-containers.cabal.rej
unpacking source archive /nix/store/ybi9kzivaj2f7n677ijm4nn45w275658-left-pad-1.3.0.tgz
note: keeping build directory '/tmp/nix-build-insert-ordered-containers-0.2.2.drv-1'

should I upgrade to master, add 8.6.4 to the patch ?

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 10, 2019

Checked patch in rev 168d103 (latest nixos-unstable) - worked build

@teto
Copy link
Member

teto commented Jun 10, 2019

yep didn't realize your commit removed the patch. For some reason home-manager didn't build with your patch, I have to investigate... tried to build just haskellPackages.insert-ordered-containers and it looked good. I am not confident enough in haskell to merge it but looks good.

@teto teto merged commit cf9acd3 into NixOS:master Jun 11, 2019
@Izorkin Izorkin deleted the insert-ordered-containers-fix-build branch June 11, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants