Fix duplicate value of client hint headers on asynchronous validation requests #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645455
branch
5 times, most recently
from
85901f9
to
614ca79
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645455
branch
2 times, most recently
from
9e8e1d9
to
664ad1f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645455
branch
from
664ad1f
to
3966ae1
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645455
branch
from
3966ae1
to
593a70e
Compare
… requests Fix issue where asynchronous validation requests (specifically, revalidation on stale-while-revalidate requests) result in a duplicate value for client hint headers (i.e. `Sec-CH-UA: Chromium 76, Chromium 76` instead of `Sec-CH-UA: Chromium 76`) Bug: 959611 Change-Id: Iac16b84b129108b9ebe1258e11722cdc9eaa52de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645455 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694763}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1645455
branch
from
593a70e
to
86b0758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where asynchronous validation requests (specifically,
revalidation on stale-while-revalidate requests) result in a duplicate
value for client hint headers (i.e.
Sec-CH-UA: Chromium 76, Chromium 76instead of
Sec-CH-UA: Chromium 76)Bug: 959611
Change-Id: Iac16b84b129108b9ebe1258e11722cdc9eaa52de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645455
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694763}