Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: 0.12.0 -> 0.12.1 #62829

Merged
merged 1 commit into from Jun 9, 2019
Merged

terraform: 0.12.0 -> 0.12.1 #62829

merged 1 commit into from Jun 9, 2019

Conversation

Veske
Copy link
Contributor

@Veske Veske commented Jun 7, 2019 •
edited

Motivation for this change

https://github.com/hashicorp/terraform/releases/tag/v0.12.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Jun 7, 2019

nox-review builds, binary appears to work macos 10.13, non-nixos linux x86_64

mmahut
mmahut approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@marsam
Copy link
Contributor

marsam commented Jun 9, 2019

@GrahamcOfBorg build terraform_0_12

@marsam marsam merged commit a2c2c38 into NixOS:master Jun 9, 2019
@marsam
Copy link
Contributor

marsam commented Jun 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Veske @risicle @marsam @mmahut